git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: David <bouncingcats@gmail.com>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
	Bert Wesarg <bert.wesarg@googlemail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: feature request, git-gui: add hotkey to toggle amend/new
Date: Tue, 3 Sep 2019 22:57:30 +0530	[thread overview]
Message-ID: <20190903172730.esy3rr4gkwxhx2s6@yadavpratyush.com> (raw)
In-Reply-To: <CAMPXz=r7hLn+aOp6B9arGMT2jxOTTpOvc0e5gm3=ttDqWNfmDA@mail.gmail.com>

On 04/09/19 01:35AM, David wrote:
> On Tue, 3 Sep 2019 at 22:45, Pratyush Yadav <me@yadavpratyush.com> wrote:
> >
> > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it
> > immediately takes me to the "Amend last commit" option. Then I can press
> > space to select it and Tab again to get back to the commit message.
> 
> Hi Pratyush Yadav,
> 
> Yes, we know it can be done this way. The point being made is not
> "this cannot be changed with the keyboard". We know that you can
> fool around with the tab key and the shift key and the spacebar and
> eventually you can succeed in changing this option.

Yes, but what Birger was saying was hitting Ctrl+Tab 9-10 times to get 
to the option. This is much faster than that alternative.

My aim was to let people know what options already exist before 
proposing new ones.
 
> And if you want to toggle it back again, you have to do a slightly
> different keyboard dance, depending on where your cursor or
> highlight is currently positioned.
> 
> Rather what we (at least I) am hoping to communicate is that after you
> have done this many thousands of times, and you can do everything
> else in git-gui very fast without touching the mouse, you might also join
> us in wishing for action to be achievable with one hotkey-combination
> event that does not affect any other state, it just toggles new/amend
> commit, and is not a sequence of several multi-key actions which must
> be adapted according to the current status of other input mode actions.

Don't get me wrong. I am not against having a dedicated hotkey for 
toggling amends. I think it is a common enough operation to warrant a 
dedicated keyboard toggle. I was just letting everyone know what the 
current options are, so they can make better judgements whether they 
really need this option or not.

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2019-09-03 17:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 10:51 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 16:25 ` Birger Skogeng Pedersen
2019-09-02 18:07   ` Bert Wesarg
2019-09-02 19:49     ` Birger Skogeng Pedersen
2019-09-02 19:56       ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03  8:52         ` Bert Wesarg
2019-09-03 10:25           ` Bert Wesarg
2019-09-03 16:20           ` Bert Wesarg
2019-09-02 20:12       ` feature request, git-gui: add hotkey to toggle amend/new Bert Wesarg
2019-09-02 20:15         ` Bert Wesarg
2019-09-03  5:37           ` Birger Skogeng Pedersen
2019-09-03 12:45             ` Pratyush Yadav
2019-09-03 14:06               ` Birger Skogeng Pedersen
2019-09-03 17:34                 ` Pratyush Yadav
2019-09-03 15:35               ` David
2019-09-03 17:27                 ` Pratyush Yadav [this message]
2019-09-04  6:24               ` Johannes Sixt
2019-09-04 17:46                 ` Pratyush Yadav
2019-09-04 17:54                   ` Birger Skogeng Pedersen
2019-09-04 18:52                   ` Johannes Sixt
2019-09-04 19:03                     ` Bert Wesarg
2019-09-10  8:54                       ` David Aguilar
2019-09-11 10:27                         ` Birger Skogeng Pedersen
2019-09-11 18:34                           ` Pratyush Yadav
2019-09-11 18:47                             ` Pratyush Yadav
2019-09-03  1:01     ` David
2019-09-03  8:44       ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903172730.esy3rr4gkwxhx2s6@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=bert.wesarg@googlemail.com \
    --cc=birger.sp@gmail.com \
    --cc=bouncingcats@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).