From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
git@vger.kernel.org, entwicklung@pengutronix.de
Subject: Re: git slow unless piped to cat
Date: Tue, 27 Aug 2019 12:04:27 +0200 [thread overview]
Message-ID: <20190827100427.u3a5uvmylm5vddn2@pengutronix.de> (raw)
In-Reply-To: <20190827094407.GV20404@szeder.dev>
On Tue, Aug 27, 2019 at 11:44:07AM +0200, SZEDER Gábor wrote:
> On Tue, Aug 27, 2019 at 11:12:06AM +0200, Philipp Zabel wrote:
> > On Tue, 2019-08-27 at 10:56 +0200, Uwe Kleine-König wrote:
> > > On Tue, Aug 27, 2019 at 10:41:11AM +0200, SZEDER Gábor wrote:
> > > > On Tue, Aug 27, 2019 at 10:15:59AM +0200, Uwe Kleine-König wrote:
> > > > > I have a problem here with git being slow in some situations.
> > > > > Using git 2.23.0 (from Debian) the effect is:
> > > > >
> > > > > ukl@dude.ptx:/ptx/src/git/linux.git$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"; time git show v5.2
> > > > > tag v5.2
> > > > > ...
> > > > >
> > > > > real 0m12.727s
> > > > > user 0m0.300s
> > > > > sys 0m0.371s
> > > > >
> > > > > But to get the actual data isn't the problem:
> > > > >
> > > > > ukl@dude.ptx:/ptx/src/git/linux.git$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"; time git show v5.2 | cat
> > > > > tag v5.2
> > > > > ...
> > > > >
> > > > > real 0m0.764s
> > > > > user 0m0.014s
> > > > > sys 0m0.020s
> > > > >
> > > >
> > > > How does 'git --no-pager show v5.2' perform? If it's as fast as the
> > > > case piping the output to cat, then look into what pager and pager
> > > > options you use.
> > >
> > > ukl@dude.ptx:/ptx/src/git/linux.git$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"; time git --no-pager show v5.2
> > > tag v5.2
> > > ...
> > >
> > > real 0m13.225s
> > > user 0m0.355s
> > > sys 0m0.336s
> > >
> > > So this doesn't seem to be the problem. Also the local configuration
> > > can be ruled out:
> > >
> > > ukl@dude.ptx:/ptx/src/git/linux.git$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"; time env GIT_CONFIG_NOSYSTEM=1 HOME=/nonexistant XDG_CONFIG_HOME=/nonexistant git --no-pager show --no-color v5.2
> > > tag v5.2
> > > ...
> > >
> > > real 0m13.587s
> > > user 0m0.335s
> > > sys 0m0.336s
> > >
> > > Thanks
> > > Uwe
> >
> > Have you checked strace output? I see a directory walk through .git/refs
> > and .git/packed-refs if the output is not redirected.
>
> That's a good point, 'git show/log' show decorations (refs pointing to
> any commits shown) when the output is a terminal:
>
> $ git show v5.2
> [...]
> commit 0ecfebd2b52404ae0c54a878c872bb93363ada36 (HEAD -> master, tag: v5.2)
> [...]
> $ git show v5.2 |cat
> [...]
> commit 0ecfebd2b52404ae0c54a878c872bb93363ada36
> [...]
> And indeed, if you have a lot of refs and cold cache, then that might
> account for a couple of seconds difference. So, how does 'git show
> --no-decorate v5.2' perform, and if it performs well, then how many
> refs do you have ('git for-each-ref |wc -l')?
$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"; time env GIT_CONFIG_NOSYSTEM=1 HOME=/nonexistant XDG_CONFIG_HOME=/nonexistant git --no-pager show --no-color --no-decorate v5.2
...
real 0m1.041s
user 0m0.000s
sys 0m0.021s
$ git for-each-ref |wc -l
10013
So this is indeed the problem.
I'm a bit surprised that the default for --decorate depends on the
output being a terminal.
Thanks for your help, I will think about what I want to do. Just using
--no-decorate will work, but isn't nice either. Will test if just
throwing away all those tags from linux-next will make this already
better.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-27 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 8:15 git slow unless piped to cat Uwe Kleine-König
2019-08-27 8:41 ` SZEDER Gábor
2019-08-27 8:56 ` Uwe Kleine-König
2019-08-27 9:12 ` Philipp Zabel
2019-08-27 9:44 ` SZEDER Gábor
2019-08-27 10:04 ` Uwe Kleine-König [this message]
2019-08-27 10:33 ` SZEDER Gábor
2019-08-27 10:56 ` Uwe Kleine-König
2019-08-27 11:28 ` Michal Suchánek
2019-08-27 18:59 ` Jeff King
2019-08-27 21:32 ` Uwe Kleine-König
2019-08-27 21:38 ` Bryan Turner
2019-08-28 10:24 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827100427.u3a5uvmylm5vddn2@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=entwicklung@pengutronix.de \
--cc=git@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).