From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] packfile: free packed_git memory when closing object store
Date: Tue, 27 Aug 2019 09:25:32 +0900 [thread overview]
Message-ID: <20190827002532.aqjbik6haoa5axhj@glandium.org> (raw)
In-Reply-To: <xmqqftlnhkd6.fsf@gitster-ct.c.googlers.com>
On Mon, Aug 26, 2019 at 11:06:29AM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > Signed-off-by: Mike Hommey <mh@glandium.org>
> > ---
> > packfile.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > Note, I'm not sure this is the right place to do it.
>
> I do not think this patch is complete, given that o->packed_git
> still has a non-NULL pointer. IIRC, close_pack() was written for
> the explicit purpose of releasing resources while allowing us to
> reopen with open_packed_git() on it, so with the current
> arrangement, after releasing the resources held for this object
> store and doing something else, you should be able to come back to
> this object store and work in it again---this patch makes it harder
> if not impossible to do so.
>
> I _think_ the patch is OK if you assigned NULL to o->packed_git,
> after making sure that the intention of all the callers of
> close_object_store() is to declare that this object store will not
> be accessed any longer during the lifetime of the process, and write
> it down as the contract between the callers and this function in a
> comment perhaps in packfile.h where the function is declared.
Maybe it would make more sense to do the complete cleanup in
raw_object_store_clear, then?
Relatedly, while looking around the other things that close_object_store
does, I saw that multi_pack_index is a sort of linked list... and
close_midx doesn't follow the links. Which raises the question whether
it should, or whether close_object_store should (considering it's
similar to packed_git in that regard, it would seem like
close_object_store should). It also raises the question what should be
free()ing multi_pack_index, because like packed_git, it's not free()d.
Mike
prev parent reply other threads:[~2019-08-27 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 2:45 [PATCH] packfile: free packed_git memory when closing object store Mike Hommey
2019-08-26 18:06 ` Junio C Hamano
2019-08-27 0:25 ` Mike Hommey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827002532.aqjbik6haoa5axhj@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).