From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Ibrahim El <ibrahim.el@pm.me>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] New signing interface API with pluggable drivers
Date: Mon, 26 Aug 2019 23:15:43 +0000 [thread overview]
Message-ID: <20190826231543.GD11334@genre.crustytoothpaste.net> (raw)
In-Reply-To: <tz1YiiRtWStGrH2sc42DyD-8bDtH1A52rOCCapct59Qos6jEikqscvusUs7QeOBRNmCF7L_AL1ezKurbTp6qEZCmEk7L9B28wH-TVQGBSdY=@pm.me>
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
On 2019-08-26 at 19:57:45, Ibrahim El wrote:
> Following previous introduction mail [1], this first series of 5 patches is a re-write of the signing interface API in an effort to support easily the addition of new tools with minimal effort and also keeping backwards compatibility with current tools and configuration.
>
> All existing tests currently pass with backward compatibility.
>
> [1]: https://public-inbox.org/git/CACi-FhDeAZecXSM36zroty6kpf2BCWLS=0R+dUwuB96LqFKuTA@mail.gmail.com/T/#r43cbf31b86642ab5118e6e7b3d4098bade5f5a0a
>
> The patches are ordered as follow:
> [1/5] - Adding Documentation files explaining the different changes using a design document and updates to the configuration part
> [2/5] - Adding new files that define the signing interface API and also drivers for the existing GPG and GPGSM X.509 tools
> [3/5] - Migrating the code to using the new signing interface API. Old GPG Interface code is commented and ommited
> [4/5] - Removing the old GPG interface and updating the code to remove all gpg mentions from it to make it transparent to the signing tool that is being used
> [5/5] - Duplicating existing signature related tests and updating them to using the new configuration aliases
I haven't done an in-depth review of this series, but I did point out a
few things that stood out to me. I think the consensus on the list in
the past was that for adding future tools, we'd like the drivers to be
configuration-based so that Git need not learn about every signing tool.
I think such a change would be welcome if done right.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-08-26 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 19:57 [PATCH 0/5] New signing interface API with pluggable drivers Ibrahim El
2019-08-26 23:15 ` brian m. carlson [this message]
2019-08-27 18:49 ` Ibrahim El
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826231543.GD11334@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=ibrahim.el@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).