* [PATCH] packfile.h: drop extern from function declaration
@ 2019-08-19 6:26 Denton Liu
2019-08-23 6:00 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Denton Liu @ 2019-08-19 6:26 UTC (permalink / raw)
To: Git Mailing List; +Cc: Jeff King, Derrick Stolee
In 336226c259 (packfile.h: drop extern from function declarations,
2019-04-05), `extern` was removed from function declarations because
it's redundant. However, in 8434e85d5f (repack: refactor pack deletion
for future use, 2019-06-10), an `extern` was mistakenly included.
Remove this spurious `extern`.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
packfile.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.h b/packfile.h
index 3e98910bdd..fc7904ec81 100644
--- a/packfile.h
+++ b/packfile.h
@@ -100,7 +100,7 @@ struct packed_git *add_packed_git(const char *path, size_t path_len, int local);
* Does not unlink if 'force_delete' is false and the pack-file is
* marked as ".keep".
*/
-extern void unlink_pack_path(const char *pack_name, int force_delete);
+void unlink_pack_path(const char *pack_name, int force_delete);
/*
* Make sure that a pointer access into an mmap'd index file is within bounds,
--
2.23.0.248.g3a9dd8fb08
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] packfile.h: drop extern from function declaration
2019-08-19 6:26 [PATCH] packfile.h: drop extern from function declaration Denton Liu
@ 2019-08-23 6:00 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2019-08-23 6:00 UTC (permalink / raw)
To: Denton Liu; +Cc: Git Mailing List, Derrick Stolee
On Mon, Aug 19, 2019 at 02:26:19AM -0400, Denton Liu wrote:
> In 336226c259 (packfile.h: drop extern from function declarations,
> 2019-04-05), `extern` was removed from function declarations because
> it's redundant. However, in 8434e85d5f (repack: refactor pack deletion
> for future use, 2019-06-10), an `extern` was mistakenly included.
>
> Remove this spurious `extern`.
Thanks. This looks obviously correct.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-23 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 6:26 [PATCH] packfile.h: drop extern from function declaration Denton Liu
2019-08-23 6:00 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).