From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (Thursday, Aug 15)
Date: Fri, 16 Aug 2019 14:15:16 -0400 [thread overview]
Message-ID: <20190816181515.GA15741@sigill.intra.peff.net> (raw)
In-Reply-To: <20190816181103.GA13894@sigill.intra.peff.net>
On Fri, Aug 16, 2019 at 02:11:03PM -0400, Jeff King wrote:
> if (opts->ignore_whitespace) {
> struct strbuf buf = STRBUF_INIT;
>
> if (strategy_opts)
> strbuf_addstr(&buf, strategy_opts);
>
> strbuf_addstr(&buf, " --ignore-space-change");
> free(strategy_opts);
> strategy_opts = strbuf_detach(&buf, NULL);
> }
> [...]
> (As an aside, this code leaks the newly allocated buffer and leaves a
> dangling pointer in opts->strategy_opts, but that's all orthogonal to
> the uncovered line; I'll send a separate message to the original
> author).
In case any of you were on the edge of your seat waiting for more
discussion, it turns out that Phillip already noticed this problem
during review:
https://public-inbox.org/git/a505fdf3-5926-9765-21ef-b82334a3fba4@gmail.com/
So nothing to see here. :)
-Peff
next prev parent reply other threads:[~2019-08-16 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 2:01 Git Test Coverage Report (Thursday, Aug 15) Derrick Stolee
2019-08-16 18:11 ` Jeff King
2019-08-16 18:15 ` Jeff King [this message]
2019-08-20 12:54 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816181515.GA15741@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).