completion: checkout.* not being completed in zsh

completion: checkout.* not being completed in zsh

[Pratyush Yadav]

Hi everyone,

I just noticed that checkout.* is not being completed in zsh. I wanted 
to set checkout.defaultRemote, but zsh would not auto-complete it.

When I do:

$ git config check<Tab>

zsh does not auto-fill "checkout."

Doing the same in bash works, so the functionality is there, it just 
doesn't work in zsh.

Once I add checkout.defaultRemote to my git config, autocompletion 
starts working, but only for defaultRemote, even though checkout has two 
options: defaultRemote and optimizeNewBranch.

To make it clear, this is what happens once I have added 
checkout.defaultRemote to my config:

$ git config check<Tab>
$ git config checkout.  # Completes to "checkout.". Correct behaviour.
$ git config checkout.<Tab>

# Completes to defaultRemote, even though it should ask between 
# defaultRemote and optimizeNewBranch
$ git config checkout.defaultRemote

I tried looking at contrib/completion, and I can see that zsh completion 
works on top of bash completion, so I don't know why exactly it works 
for bash but not for zsh.

I am not too familiar with how these auto completion scripts work, so if 
someone can point me in the right direction, I'll see if I can figure 
out a fix and submit it here.

-- 
Regards,
Pratyush Yadav

Re: completion: checkout.* not being completed in zsh

[brian m. carlson]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On 2019-08-15 at 19:50:27, Pratyush Yadav wrote:
> I tried looking at contrib/completion, and I can see that zsh completion
> works on top of bash completion, so I don't know why exactly it works
> for bash but not for zsh.
> 
> I am not too familiar with how these auto completion scripts work, so if
> someone can point me in the right direction, I'll see if I can figure
> out a fix and submit it here.

zsh uses its own completion system which is substantially different from
the bash one and includes definitions for most programs shipped with it.
Are you sure you're using the Git-shipped completions and not the ones
shipped with zsh?
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]

Re: completion: checkout.* not being completed in zsh

[Pratyush Yadav]

On 16/08/19 02:36AM, brian m. carlson wrote:
> On 2019-08-15 at 19:50:27, Pratyush Yadav wrote:
> > I tried looking at contrib/completion, and I can see that zsh completion
> > works on top of bash completion, so I don't know why exactly it works
> > for bash but not for zsh.
> > 
> > I am not too familiar with how these auto completion scripts work, so if
> > someone can point me in the right direction, I'll see if I can figure
> > out a fix and submit it here.
> 
> zsh uses its own completion system which is substantially different from
> the bash one and includes definitions for most programs shipped with it.
> Are you sure you're using the Git-shipped completions and not the ones
> shipped with zsh?

Yes, you are correct. I was using the zsh shipped completion. Using the 
git shipped completion fixes this. Thanks.

-- 
Regards,
Pratyush Yadav