From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Hong Xu <hong@topbug.net>,
git@vger.kernel.org
Subject: Re: [PATCH] diff: 'diff.indentHeuristic' is no longer experimental
Date: Thu, 15 Aug 2019 09:56:28 -0400 [thread overview]
Message-ID: <20190815135628.GA27091@sigill.intra.peff.net> (raw)
In-Reply-To: <20190815091245.16525-1-szeder.dev@gmail.com>
On Thu, Aug 15, 2019 at 11:12:45AM +0200, SZEDER Gábor wrote:
> The indent heuristic started out as experimental, but it's now our
> default diff heuristic since 33de716387 (diff: enable indent heuristic
> by default, 2017-05-08). Alas, that commit didn't update the
> documentation, and the description of the 'diff.indentHeuristic'
> configuration variable still implies that it's experimental and not
> the default.
>
> Update the description of 'diff.indentHeuristic' to make it clear that
> it's the default diff heuristic.
>
> The description of the related '--indent-heuristic' option has already
> been updated in bab76141da (diff: --indent-heuristic is no
> longer experimental, 2017-10-29).
Yeah, this makes perfect sense.
I wondered briefly if we needed to distinguish between plumbing and
porcelain here, but the config option (and its default) are the same for
both.
-Peff
next prev parent reply other threads:[~2019-08-15 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 4:38 Is diff.indentHeuristic still experimental? Hong Xu
2019-08-15 9:12 ` [PATCH] diff: 'diff.indentHeuristic' is no longer experimental SZEDER Gábor
2019-08-15 13:56 ` Jeff King [this message]
2019-08-15 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815135628.GA27091@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hong@topbug.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).