From: Jeff King <peff@peff.net>
To: Bo Zhang <zhangbodut@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Potential asterisk expansion bug in Windows Git Bash?
Date: Wed, 14 Aug 2019 08:10:46 -0400 [thread overview]
Message-ID: <20190814121045.GA30302@sigill.intra.peff.net> (raw)
In-Reply-To: <CAO=KXnspgZa=R9=8wvPY-Y8pvuAah-D+Jc4CM_+cdemYGUJ09A@mail.gmail.com>
On Wed, Aug 14, 2019 at 07:50:47PM +0800, Bo Zhang wrote:
> Today I noticed that on Windows Git Bash, the asterisk (*) is
> incorrectly expanded even when it’s in a quote or following a
> backslash (\). I’m wondering if this is the correct behaviour (which
> seems like to me NOT).
>
> Step to reproduce (in Windows git bash):
>
> zhb@zhb-PC MINGW64 ~/Desktop
> $ bash --version
> GNU bash, version 4.4.19(2)-release (x86_64-pc-msys)
> Copyright (C) 2016 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>
> This is free software; you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
>
> zhb@zhb-PC MINGW64 ~/Desktop
> $ cat 1.sh
> echo $1
Your script doesn't quote "$1", so whatever you pass in will be subject
to wildcard expansion inside the shell running the script.
Try this:
$ cat bad.sh
echo $1
$ cat good.sh
echo "$1"
$ bash bad.sh '*'
bad.sh good.sh
$ bash good.sh '*'
*
> zhb@zhb-PC MINGW64 ~/Desktop
> $ bash 1.sh '*'
> $A 1.sh 1.txt
So this is the case I showed above.
> zhb@zhb-PC MINGW64 ~/Desktop
> $ bash 1.sh "*"
> $A 1.sh 1.txt
And this is equivalent. The quotes suppress wildcard expansion in your
interactive shell, but the script itself does another round of
expansion.
> zhb@zhb-PC MINGW64 ~/Desktop
> $ bash 1.sh \*
> 1.sh 1.txt
And same here.
-Peff
next prev parent reply other threads:[~2019-08-14 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 11:50 Potential asterisk expansion bug in Windows Git Bash? Bo Zhang
2019-08-14 12:10 ` Jeff King [this message]
2019-08-14 12:38 ` Bo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814121045.GA30302@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=zhangbodut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).