From: Jeff King <firstname.lastname@example.org> To: nanaya <email@example.com> Cc: firstname.lastname@example.org Subject: Re: git grep -F (fixed string) requires matching parenthesis? Date: Tue, 13 Aug 2019 08:17:33 -0400 [thread overview] Message-ID: <20190813121733.GA10787@sigill.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Tue, Aug 13, 2019 at 03:01:04PM +0900, nanaya wrote: > I observed this today: > > $ git grep -F '(' > fatal: unmatched parenthesis > > Which doesn't make sense and I believe shouldn't happen. At first glance this looks like we're feeding a fixed-string pattern to the regex compiler, which would indeed be a bug. But I think it's actually happening at a level above that. git-grep supports multiple patterns, which can be joined with --and, --or, --not, etc. And they can be grouped with parentheses. What you're seeing is the argument parser thinking your '(' is part of the construction of a boolean match formula, and complaining about the lack of closing ')'. You can use "-e" to make it clear that it's a pattern (just as you'd need to for a pattern that starts with "-"): git grep -F -e '(' So I think everything is working as designed, though I admit the implication was slightly surprising to me (and note that it only happens with that _specific_ pattern; something like "(foo" would not be matched by the option parser). -Peff
next prev parent reply other threads:[~2019-08-13 12:17 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-13 6:01 nanaya 2019-08-13 12:17 ` Jeff King [this message] 2019-08-13 12:33 ` nanaya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190813121733.GA10787@sigill.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: git grep -F (fixed string) requires matching parenthesis?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).