From: Palmer Dabbelt <palmer@sifive.com>
To: git@vger.kernel.org
Cc: peff@peff.net, e@80x24.org, chriscool@tuxfamily.org,
gitster@pobox.com, jonathantanmy@google.com, tboegi@web.de,
bwilliams.eng@gmail.com, jeffhost@microsoft.com
Subject: [PATCH v2 0/5] fetch: Extend --jobs to multiple remotes
Date: Mon, 12 Aug 2019 14:34:43 -0700 [thread overview]
Message-ID: <20190812213448.2649-1-palmer@sifive.com> (raw)
It seems like the feedback for v1 was fairly positive, so I managed to
find some time to go ahead finish it. The result is a much cleaner
patch set. I think this could be merged in its current state, but there
are a few outstanding concerns I have:
* fetch.jobs isn't documented because I couldn't find any
documentation for submodule.fetchjobs so I didn't know where to start
writing.
* I took the complicated approach and added --submodule-fetch-jobs and
--fetch-jobs before converting --jobs over to set both. At the time I
thought it wouldn't add too much extra complexity. I wasn't looking
closely enough and ended up with a custom parsing function which is a
bit ugly.
I'm happy to fix either of these, but I wanted to send out the v2 before
going any farther because I wasn't sure if --jobs would be converted
over right away or if there was going to be a deprecation period. I've
written the patch set such that the final patch can easily be dropped to
avoid changing existing behavior.
I'm also happy to re-spin this to just make --jobs control remotes and
drop the --fetch-jobs and --submodule-fetch-jobs arguments, which would
make the patch set somewhat simpler but preclude a deprecation period.
Changes since v1 <20190717015903.4384-1-palmer@sifive.com>:
* fetch_multiple() has been rewritten to use
run_processes_parallel_tr2() rather than manage children on its own.
* The --fetch-jobs argument has been added.
* The --jobs arugemnt has been used, instead of the --parallel argument.
next reply other threads:[~2019-08-12 21:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:34 Palmer Dabbelt [this message]
2019-08-12 21:34 ` [PATCH v2 1/5] fetch: Rename max_children to max_children_for_submodules Palmer Dabbelt
2019-08-12 21:34 ` [PATCH v2 2/5] fetch: Add the "--fetch-jobs" option Palmer Dabbelt
2019-08-13 14:44 ` Eric Wong
2019-08-12 21:34 ` [PATCH v2 3/5] fetch: Add the fetch.jobs config key Palmer Dabbelt
2019-08-12 21:34 ` [PATCH v2 4/5] fetch: Add the --submodule-fetch-jobs option Palmer Dabbelt
2019-08-12 21:34 ` [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes Palmer Dabbelt
2019-08-13 20:16 ` Johannes Schindelin
2019-08-13 22:06 ` Palmer Dabbelt
2019-08-13 22:00 ` Junio C Hamano
2019-08-13 22:06 ` Palmer Dabbelt
2019-08-14 8:32 ` SZEDER Gábor
2019-08-14 15:54 ` Junio C Hamano
2019-08-14 18:33 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812213448.2649-1-palmer@sifive.com \
--to=palmer@sifive.com \
--cc=bwilliams.eng@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).