From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: johannes.schindelin@gmx.de
Cc: avarab@gmail.com, carenas@gmail.com, git@vger.kernel.org,
gitster@pobox.com, l.s.r@web.de, michal.kiedrowicz@gmail.com
Subject: [PATCH] SQUASH
Date: Fri, 9 Aug 2019 20:03:15 -0700 [thread overview]
Message-ID: <20190810030315.7519-1-carenas@gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1908092325480.46@tvgsbejvaqbjf.bet>
Make using a general context (that is only needed with NED) to depend
on NED being selected at compile time.
the compile_context could be also make conditional but it gets ugly
really fasts with #ifdef
---
Makefile | 2 +-
grep.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 8a7e235352..995e6c9351 100644
--- a/Makefile
+++ b/Makefile
@@ -1774,7 +1774,7 @@ ifdef NATIVE_CRLF
endif
ifdef USE_NED_ALLOCATOR
- COMPAT_CFLAGS += -Icompat/nedmalloc
+ COMPAT_CFLAGS += -DUSE_NED_ALLOCATOR -Icompat/nedmalloc
COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
OVERRIDE_STRDUP = YesPlease
endif
diff --git a/grep.c b/grep.c
index 8255ec956e..233072ed80 100644
--- a/grep.c
+++ b/grep.c
@@ -482,6 +482,7 @@ static void free_pcre1_regexp(struct grep_pat *p)
#endif /* !USE_LIBPCRE1 */
#ifdef USE_LIBPCRE2
+#ifdef USE_NED_ALLOCATOR
static void *pcre2_malloc(PCRE2_SIZE size, MAYBE_UNUSED void *memory_data)
{
return xmalloc(size);
@@ -491,6 +492,7 @@ static void pcre2_free(void *pointer, MAYBE_UNUSED void *memory_data)
{
free(pointer);
}
+#endif
static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt)
{
@@ -505,7 +507,9 @@ static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt
assert(opt->pcre2);
+#ifdef USE_NED_ALLOCATOR
p->pcre2_general_context = pcre2_general_context_create(pcre2_malloc, pcre2_free, NULL);
+#endif
p->pcre2_compile_context = pcre2_compile_context_create(p->pcre2_general_context);
if (opt->ignore_case) {
--
2.23.0.rc2
next prev parent reply other threads:[~2019-08-10 3:03 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 11:51 [PATCH 0/1] Fix a problem with PCRE2 and nedmalloc, found via Azure Pipelines Johannes Schindelin via GitGitGadget
2019-08-05 11:51 ` [PATCH 1/1] pcre2: allow overriding the system allocator Johannes Schindelin via GitGitGadget
2019-08-05 16:19 ` Carlo Arenas
2019-08-05 16:27 ` Carlo Arenas
2019-08-05 19:32 ` Johannes Schindelin
2019-08-05 19:26 ` Johannes Schindelin
2019-08-05 21:53 ` Junio C Hamano
2019-08-06 6:24 ` Carlo Arenas
2019-08-06 8:50 ` [PATCH 0/3] grep: no leaks (WIP) Carlo Marcelo Arenas Belón
2019-08-06 8:50 ` [PATCH 1/3] grep: make PCRE1 aware of custom allocator Carlo Marcelo Arenas Belón
2019-08-08 13:54 ` Johannes Schindelin
2019-08-08 15:19 ` Carlo Arenas
2019-08-06 8:50 ` [PATCH 2/3] grep: make PCRE2 " Carlo Marcelo Arenas Belón
2019-08-08 13:56 ` Johannes Schindelin
2019-08-08 14:32 ` Carlo Arenas
2019-08-06 8:50 ` [PATCH 3/3] grep: avoid leak of chartables in PCRE2 Carlo Marcelo Arenas Belón
2019-08-06 16:36 ` [RFC PATCH v3 0/3] grep: no leaks or crashes (windows testing needed) Carlo Marcelo Arenas Belón
2019-08-06 16:36 ` [RFC PATCH v3 1/3] grep: make PCRE1 aware of custom allocator Carlo Marcelo Arenas Belón
2019-08-06 16:36 ` [RFC PATCH v3 2/3] grep: make PCRE2 " Carlo Marcelo Arenas Belón
2019-08-07 5:38 ` René Scharfe
2019-08-07 9:49 ` Carlo Arenas
2019-08-07 13:02 ` René Scharfe
2019-08-07 13:08 ` [PATCH 1/2] nedmalloc: do assignments only after the declaration section René Scharfe
2019-08-07 13:09 ` [PATCH 2/2] nedmalloc: avoid compiler warning about unused value René Scharfe
2019-08-08 2:35 ` [RFC PATCH v3 2/3] grep: make PCRE2 aware of custom allocator Carlo Arenas
2019-08-08 7:07 ` René Scharfe
2019-08-08 12:38 ` Carlo Arenas
2019-08-08 14:29 ` René Scharfe
2019-08-08 20:18 ` Johannes Schindelin
2019-08-07 18:15 ` Junio C Hamano
2019-08-06 16:36 ` [RFC PATCH v3 3/3] grep: avoid leak of chartables in PCRE2 Carlo Marcelo Arenas Belón
2019-08-06 16:48 ` [RFC PATCH v3 0/3] grep: no leaks or crashes (windows testing needed) Junio C Hamano
2019-08-07 21:39 ` [RFC PATCH v4 " Carlo Marcelo Arenas Belón
2019-08-07 21:39 ` [RFC PATCH v4 1/3] grep: make PCRE1 aware of custom allocator Carlo Marcelo Arenas Belón
2019-08-07 21:39 ` [RFC PATCH v4 2/3] grep: make PCRE2 " Carlo Marcelo Arenas Belón
2019-08-07 22:28 ` Junio C Hamano
2019-08-07 21:39 ` [RFC PATCH v4 3/3] grep: avoid leak of chartables in PCRE2 Carlo Marcelo Arenas Belón
2019-08-09 3:02 ` [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes Carlo Marcelo Arenas Belón
2019-08-09 3:02 ` [RFC PATCH v5 1/3] grep: make PCRE1 aware of custom allocator Carlo Marcelo Arenas Belón
2019-08-09 3:02 ` [RFC PATCH v5 2/3] grep: make PCRE2 " Carlo Marcelo Arenas Belón
2019-08-27 9:07 ` Johannes Schindelin
2019-08-27 11:51 ` Carlo Arenas
2019-10-03 5:02 ` Junio C Hamano
2019-10-03 8:08 ` Johannes Schindelin
2019-10-03 11:17 ` Carlo Arenas
2019-10-03 18:23 ` Johannes Schindelin
2019-10-03 22:57 ` Junio C Hamano
2019-08-09 3:02 ` [RFC PATCH v5 3/3] grep: avoid leak of chartables in PCRE2 Carlo Marcelo Arenas Belón
2019-08-09 11:24 ` [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes Carlo Arenas
2019-08-09 17:01 ` René Scharfe
2019-08-09 17:46 ` Junio C Hamano
2019-08-09 21:26 ` Johannes Schindelin
2019-08-10 3:03 ` Carlo Marcelo Arenas Belón [this message]
2019-08-10 7:57 ` [PATCH] SQUASH René Scharfe
2019-08-10 8:42 ` Carlo Arenas
2019-08-10 19:47 ` René Scharfe
2019-08-12 7:35 ` Carlo Arenas
2019-08-12 12:14 ` René Scharfe
2019-08-12 12:28 ` Carlo Arenas
2019-08-10 13:57 ` Johannes Schindelin
2019-08-10 3:05 ` [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes Carlo Arenas
2019-08-10 7:56 ` René Scharfe
2019-08-10 12:40 ` Carlo Arenas
2019-08-10 21:16 ` René Scharfe
2019-08-08 20:21 ` [RFC PATCH v3 0/3] grep: no leaks or crashes (windows testing needed) Johannes Schindelin
2019-08-09 6:52 ` Carlo Arenas
2019-08-09 21:13 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2016-11-22 19:22 [PATCHv2 4/4] submodule: add embed-git-dir function Stefan Beller
2016-11-22 19:33 ` [PATCH] SQUASH Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810030315.7519-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
--cc=michal.kiedrowicz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).