From: Jeff King <email@example.com> To: Phil Hord <firstname.lastname@example.org> Cc: Elijah Newren <email@example.com>, Git Mailing List <firstname.lastname@example.org> Subject: Re: [PATCH 1/1] delete multiple tags in a single transaction Date: Thu, 8 Aug 2019 23:05:31 -0400 [thread overview] Message-ID: <20190809030531.GA14576@sigill.intra.peff.net> (raw) In-Reply-To: <CABURp0p5xbsq+8UsFerMAY8EG-ndXgd19EUsHOgQG-dnDnTAgg@mail.gmail.com> On Thu, Aug 08, 2019 at 04:43:16PM -0700, Phil Hord wrote: > > I also get really slow times on a repo with ~20,000 tags (though order > > ~3 minutes rather than ~30, probably due to having an SSD on this > > machine) -- but ONLY IF the refs are packed first (git pack-refs > > --all). If the refs are loose, it's relatively quick to delete a > > dozen thousand or so tags (order of a few seconds). It might be worth > > mentioning in the commit message that this only makes a significant > > difference in the case where the refs are packed. > > I'm also using an SSD but I still see about 10 tags per second being > deleted with the current code (and packed-refs). I see that I'm > CPU-bound, so I guess most of the time is spent searching through > .git/packed-refs. Probably it will run faster as it progresses. I > guess the 18,000 branches in my repo keep me on the wrong end of O(N). Right, deleting individually from packed-refs is inherently quadratic, because each deletion has to rewrite the entire file. So if you delete all (or the majority of them), that's O(n^2) individual entry writes. The loose case is just touching the filesystem for each entry (and the refs code is smart enough not to bother rewriting packed-refs if the entry isn't present there). That _can_ be slow if you have a lot of entries in the same directory (because some filesystems are particularly bad at this). So the actual backing storage speed isn't really that important. All the time goes to copying the same packed-refs entries over and over, whether they hit the disk or not. Your solution (using a single transaction) is definitely the right one (and probably should apply to "branch -d", too). That's what we did long ago for update-ref, and I think nobody ever really noticed for the porcelain commands because they don't tend to be used for such bulk changes. > But it should have occurred to me while I was in the code that there > is a different path for unpacked refs which could explain my previous > speeds. I didn't think I had any unpacked refs, though, since every > time I look in .git/refs for what I want, I find it relatively empty. > I see 'git pack-refs --help' says that new refs should show up loose, > but I can't say that has happened for me. Maybe a new clone uses > packed-refs for *everything* and only newly fetched things are loose. > Is that it? I guess since I seldom fetch tags after the first clone, > it makes sense they would all be packed. Right, a fresh clone always writes all of its entries as packed refs. It used to be done by hand, but it happens in a special "initial transaction" method these days, since 58f233ce1e (initial_ref_transaction_commit(): function for initial ref creation, 2015-06-22). > > In constrast, it appears that `git update-ref --stdin` is fast > > regardless of whether the refs are packed, e.g. > > git tag -l feature/* | sed -e 's%^%delete refs/tags/%' | git > > update-ref --stdin > > finishes quickly (order of a few seconds). > > Nice! That trick is going in my wiki for devs to use on their VMs. > Thanks for that. Please do encourage people to use for-each-ref instead of the "tag -l" porcelain, as the latter is subject to change. My usual bulk deletion command is: git for-each-ref --format='delete %(refname)' refs/tags/feature/ | git update-ref --stdin -Peff
next prev parent reply other threads:[~2019-08-09 3:05 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-08 3:59 Phil Hord 2019-08-08 12:47 ` Martin Ågren 2019-08-08 12:53 ` [PATCH] t7004: check existence of correct tag Martin Ågren 2019-08-08 18:15 ` [PATCH 1/1] delete multiple tags in a single transaction Elijah Newren 2019-08-08 23:43 ` Phil Hord 2019-08-09 3:05 ` Jeff King [this message] 2019-08-08 19:39 ` Junio C Hamano 2019-08-08 23:58 ` Phil Hord
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190809030531.GA14576@sigill.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/1] delete multiple tags in a single transaction' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).