From: "SZEDER Gábor" <firstname.lastname@example.org>
To: "brian m. carlson" <email@example.com>
Cc: Jeff King <firstname.lastname@example.org>, Jonathan Nieder <email@example.com>,
firstname.lastname@example.org, Duy Nguyen <email@example.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jonathan Tan <firstname.lastname@example.org>,
Eric Sunshine <email@example.com>,
Junio C Hamano <firstname.lastname@example.org>
Subject: Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path
Date: Thu, 8 Aug 2019 14:58:05 +0200 [thread overview]
Message-ID: <20190808125805.GH20404@szeder.dev> (raw)
On Thu, Aug 08, 2019 at 11:35:38AM +0000, brian m. carlson wrote:
> On 2019-08-08 at 09:37:33, Jeff King wrote:
> > On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
> > -- >8 --
> > Subject: [PATCH] t0000: reword comments for "local" test
> > Commit 01d3a526ad (t0000: check whether the shell supports the "local"
> > keyword, 2017-10-26) added a test to gather data on whether people run
> > the test suite with shells that don't support "local".
> > After almost two years, nobody has complained, and several other uses
> > have cropped up in test-lib-functions.sh. Let's declare it acceptable to
> > use.
> I'm also in favor of this patch. To my knowledge, the only FLOSS
> POSIX-compliant shell that doesn't support "local" is AT&T ksh, so there
> are a lot of alternatives that folks have (bash, dash, posh, zsh, mksh,
> pdksh, busybox sh, etc.) in case they have a less capable shell.
From these shells:
- dash and Bash work; no surprise there, being the default shells in
some of the most popular Linux distros and GfW.
- mksh works as well (just don't hit ctrl-C while running a test
involving a daemon with '--verbose-log').
- Zsh seems to be fundamentally incapable to run our test
- BusyBox sh is fine for the most part, but there are a few test
failures, where we rely on some options or capabilities of various
system commands that are not supported by the corresponding
- posh can successfully run a lot of test scripts, but there are a
lot of failures as well, it skips a few test scripts that it
shouldn't (claiming that Perl and Bash are not available?!), and
t0000 aborts with a 'bug in test framework' error. What's most
worrying is that it reported a few "known breakage fixed" cases as
- pdksh seems to be unavailable in my Linux distro, but since its
name contains the "ksh" substring I'm sceptical.
So there are not that many alternatives.
Having said that, I'm in favor of using 'local'.
next prev parent reply other threads:[~2019-08-08 12:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 22:59 [PATCH v3 00/10] Hash-independent tests, part 4 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 01/10] t: add helper to convert object IDs to paths brian m. carlson
2019-08-08 6:56 ` [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path Jonathan Nieder
2019-08-08 9:37 ` Jeff King
2019-08-08 11:35 ` brian m. carlson
2019-08-08 12:58 ` SZEDER Gábor [this message]
2019-08-08 17:22 ` Junio C Hamano
2019-08-08 11:25 ` brian m. carlson
2019-06-28 22:59 ` [PATCH v3 02/10] t1410: make hash size independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 03/10] t1450: " brian m. carlson
2019-06-28 22:59 ` [PATCH v3 04/10] t5000: make hash independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 05/10] t6030: make test work with SHA-256 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 06/10] t0027: make hash size independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 07/10] t0090: make test pass with SHA-256 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 08/10] t1007: remove SHA1 prerequisites brian m. carlson
2019-06-28 22:59 ` [PATCH v3 09/10] t1710: make hash independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 10/10] t2203: avoid hard-coded object ID values brian m. carlson
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).