From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Duy Nguyen <pclouds@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jonathan Tan <jonathantanmy@google.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path
Date: Thu, 8 Aug 2019 11:25:45 +0000 [thread overview]
Message-ID: <20190808112545.GJ118825@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20190808065614.GA209195@google.com>
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
On 2019-08-08 at 06:56:14, Jonathan Nieder wrote:
> t1410.3 ("corrupt and checks") fails when run using dash versions
> before 0.5.8, with a cryptic message:
>
> mv: cannot stat '.git/objects//e84adb2704cbd49549e52169b4043871e13432': No such file or directory
>
> The function generating that path:
>
> test_oid_to_path () {
> echo "${1%${1#??}}/${1#??}"
> }
>
> which is supposed to produce a result like
>
> 12/3456789....
>
> But a dash bug[*] causes it to instead expand to
>
> /3456789...
>
> The stream of symbols that makes up this function is hard for humans
> to follow, too. The complexity mostly comes from the repeated use of
> the expression ${1#??} for the basename of the loose object. Use a
> variable instead --- nowadays, the dialect of shell used by Git
> permits local variables, so this is cheap.
>
> An alternative way to work around [*] is to remove the double-quotes
> around test_oid_to_path's return value. That makes the expression
> easier for dash to read, but harder for humans. Let's prefer the
> rephrasing that's helpful for humans, too.
>
> Noticed by building on Ubuntu trusty, which uses dash 0.5.7.
This seems like a sane, well-reasoned fix. I don't know if we care about
building on Ubuntu trusty (since it is EOL), but if we do, then we
should definitely take this patch.
I agree it makes things easier to follow as well, which is also nice,
and it preserves the shell-only nature that's so desirable on Windows.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-08-08 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 22:59 [PATCH v3 00/10] Hash-independent tests, part 4 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 01/10] t: add helper to convert object IDs to paths brian m. carlson
2019-08-08 6:56 ` [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path Jonathan Nieder
2019-08-08 9:37 ` Jeff King
2019-08-08 11:35 ` brian m. carlson
2019-08-08 12:58 ` SZEDER Gábor
2019-08-08 17:22 ` Junio C Hamano
2019-08-08 11:25 ` brian m. carlson [this message]
2019-06-28 22:59 ` [PATCH v3 02/10] t1410: make hash size independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 03/10] t1450: " brian m. carlson
2019-06-28 22:59 ` [PATCH v3 04/10] t5000: make hash independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 05/10] t6030: make test work with SHA-256 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 06/10] t0027: make hash size independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 07/10] t0090: make test pass with SHA-256 brian m. carlson
2019-06-28 22:59 ` [PATCH v3 08/10] t1007: remove SHA1 prerequisites brian m. carlson
2019-06-28 22:59 ` [PATCH v3 09/10] t1710: make hash independent brian m. carlson
2019-06-28 22:59 ` [PATCH v3 10/10] t2203: avoid hard-coded object ID values brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808112545.GJ118825@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).