git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] sha1-file: release strbuf after use
Date: Wed, 7 Aug 2019 08:49:00 -0400	[thread overview]
Message-ID: <20190807124859.GA5384@sigill.intra.peff.net> (raw)
In-Reply-To: <fa6ccb9f-11cd-7eec-fdbb-2de6a0bfcecf@web.de>

On Wed, Aug 07, 2019 at 01:15:25PM +0200, René Scharfe wrote:

> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Patch generated with --function-context for easier review.
> 
> The plugged leak was added by a10a17877b (for_each_alternate_ref:
> replace transport code with for-each-ref, 2017-02-08) and showed up in
> 709dfa6990 (object-store.h: move for_each_alternate_ref() from
> transport.h, 2019-07-01), where it caught my eye, belatedly.

Thanks, the patch obviously looks good (though I wouldn't be sad for
some of your digging above to go into the commit message).

I had a vague feeling that we had seen this particular leak before (and
presumably the fix fell through the cracks). But I couldn't find it on
the list. I think after a while these strbuf_getline() leaks all start
to look the same. :)

-Peff

  reply	other threads:[~2019-08-07 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 11:15 [PATCH] sha1-file: release strbuf after use René Scharfe
2019-08-07 12:49 ` Jeff King [this message]
2019-08-07 13:51 ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807124859.GA5384@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).