From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, peff@peff.net, avarab@gmail.com,
jrnieder@google.com, steadmon@google.com,
Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] commit-graph: fix bug around octopus merges
Date: Tue, 6 Aug 2019 17:19:49 +0200 [thread overview]
Message-ID: <20190806151949.GF20404@szeder.dev> (raw)
In-Reply-To: <ec14865f-98cb-5e1a-b580-8b6fddaa6217@gmail.com>
On Tue, Aug 06, 2019 at 08:03:07AM -0400, Derrick Stolee wrote:
> > On the other hand, one of my fun side-projects is to run some
> > semi-automated and souped-up CI builds of currently cooking topics,
> > which include a custom GETTEXT_POISON mode [1], where the poisoned
> > translated progress output in this new test looks like this [2]:
> >
> > V.e.r.i.f.y.i.n.g. .c.o.m.m.i.t.s. .i.n. .c.o.m.m.i.t. .g.r.a.p.h.: 100% (1/1), d.o.n.e..
> > V.e.r.i.f.y.i.n.g. .c.o.m.m.i.t.s. .i.n. .c.o.m.m.i.t. .g.r.a.p.h.: 100% (5/5), d.o.n.e..
> > V.e.r.i.f.y.i.n.g. .c.o.m.m.i.t.s. .i.n. .c.o.m.m.i.t. .g.r.a.p.h.:
> > 100% (12/12), d.o.n.e..
> >
> > So this makes the progress lines almost twice as long, and as the last
> > commit-graph file contains double-digit commits, the length of the
> > progress line just happens to exceed the width of a 80 character
> > terminal, and gets line wrapped. This throws off the line count
> > check, as there are now 4 lines on standard error instead of the
> > expected 3.
>
> Thanks for pointing out that the poison runs can change the number of lines.
Hm, I'm afraid I was not clear enough, so let me clarify.
A "regular" GIT_TEST_GETTEXT_POISON=1 test run does not change the
number of lines. After it replaces the translated string with the '#
GETTEXT POISON #' magic, the progress output will look like this:
# GETTEXT POISON #: 41% (5/12)
This will never grow long enough to trigger a line break.
It's just one of my fun experiments [1] that makes translated strings
twice as long, and thus triggers that line break.
[1] https://github.com/szeder/git gettext-poison-scrambled-msg
prev parent reply other threads:[~2019-08-06 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 16:43 [PATCH 0/1] [v2.23.0 BUG] commit-graph: fix bug around octopus merges Derrick Stolee via GitGitGadget
2019-08-05 16:43 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-08-06 9:21 ` SZEDER Gábor
2019-08-06 12:03 ` Derrick Stolee
2019-08-06 15:19 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806151949.GF20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jrnieder@google.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).