list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Liam Beguin <>
Cc: Liam Beguin <>
Subject: [PATCH 1/1] commit: add signoff config variable
Date: Sat,  3 Aug 2019 15:34:36 -0400	[thread overview]
Message-ID: <> (raw)

Add a configuration variable, based on format.signoff, to automatically
signoff commit messages.

Signed-off-by: Liam Beguin <>
 Documentation/config/commit.txt | 7 +++++++
 builtin/commit.c                | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/Documentation/config/commit.txt b/Documentation/config/commit.txt
index 2c95573930be..62aaacb0dc74 100644
--- a/Documentation/config/commit.txt
+++ b/Documentation/config/commit.txt
@@ -27,3 +27,10 @@ commit.template::
 	A boolean or int to specify the level of verbose with `git commit`.
 	See linkgit:git-commit[1].
+	A boolean value which lets you enable the `-s/--signoff` option of
+	`git commit` by default. *Note:* Adding the Signed-off-by: line to a
+	patch should be a conscious act and means that you certify you have
+	the rights to submit this work under the same open source license.
+	Please see the 'SubmittingPatches' document for further discussion.
diff --git a/builtin/commit.c b/builtin/commit.c
index ae7aaf6dc683..36d70396ace7 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1456,6 +1456,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)
 		config_commit_verbose = git_config_bool_or_int(k, v, &is_bool);
 		return 0;
+	if (!strcmp(k, "commit.signoff")) {
+		signoff = git_config_bool(k, v);
+		return 0;
+	}
 	status = git_gpg_config(k, v, NULL);
 	if (status)

             reply	other threads:[~2019-08-03 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-03 19:34 Liam Beguin [this message]
2019-08-03 21:11 ` brian m. carlson
2019-08-03 21:23   ` Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --subject='Re: [PATCH 1/1] commit: add signoff config variable' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).