From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B06511F731 for ; Fri, 2 Aug 2019 18:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405915AbfHBSfb (ORCPT ); Fri, 2 Aug 2019 14:35:31 -0400 Received: from cloud.peff.net ([104.130.231.41]:60700 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2405370AbfHBSfa (ORCPT ); Fri, 2 Aug 2019 14:35:30 -0400 Received: (qmail 10769 invoked by uid 109); 2 Aug 2019 18:35:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 02 Aug 2019 18:35:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9103 invoked by uid 111); 2 Aug 2019 18:37:29 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 02 Aug 2019 14:37:29 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 2 Aug 2019 14:35:29 -0400 From: Jeff King To: Junio C Hamano Cc: Jonathan Nieder , Johannes Schindelin , git-for-windows@googlegroups.com, git@vger.kernel.org, git-packagers@googlegroups.com, Ariadne Conill Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0 Message-ID: <20190802183529.GA26918@sigill.intra.peff.net> References: <20190731231848.GC1933@sigill.intra.peff.net> <20190801002125.GA176307@google.com> <20190802022709.GB54514@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 02, 2019 at 09:53:55AM -0700, Junio C Hamano wrote: > Jonathan Nieder writes: > > > We'll also want to update the docs. And as Todd suggests, we should > > cover how to disable mailmap in tests. > > > > Signed-off-by: Jonathan Nieder > > --- > > I avoided the "don't bother initializing use_mailmap_config to > unknown" simplification, but I guess the change is clear enough. Yeah, I didn't even look to see if there were further simplifications possible, but seeing Jonathan's patch, it looks like an obvious improvement. And a quick grep shows that there are no other sites that should be affected by losing the "-1" semantics, so I think it's a good idea. And of course the doc and test improvements are very welcome. :) -Peff