From: Jeff King <peff@peff.net>
To: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Cc: git@vger.kernel.org
Subject: Re: Support for --stdin-paths in commit, add, etc
Date: Wed, 31 Jul 2019 13:19:57 -0400 [thread overview]
Message-ID: <20190731171956.GA26746@sigill.intra.peff.net> (raw)
In-Reply-To: <a38bc928-7ccd-e2d9-b89b-23298e9fa95d@syntevo.com>
On Wed, Jul 31, 2019 at 05:45:12PM +0200, Alexandr Miloslavskiy wrote:
> In our git UI, we sometimes run into OS commandline length limit when
> trying to specify a list of pathspecs. For example, this happens when
> user selects a large set of files and wants to commit them. As a
> workaround, we split files and issue multiple git commands.
>
> This has multiple disadvantages:
> 1) Some commands are a lot slower this way. For example, commit-amend
> can take 45 minutes instead of 30 seconds, because git will do a lot
> of unnecessary work.
> 2) The operation is no longer completed in one "transaction".
> 3) This makes our code more complicated.
>
> Our suggestion is to change commands such as 'commit', 'add', etc to
> also work with --stdin-paths. If a command already supports stdin for
> any purpose, then trying to use both options will return an error.
I don't have any real objection to adding stdin support for more
commands. Bu tin the specific case you're discussing, it seems like
using "git update-index" might already solve your problem. It's the
intended plumbing for scripted index updates, and it already supports
receiving paths from stdin.
-Peff
next prev parent reply other threads:[~2019-07-31 17:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:45 Support for --stdin-paths in commit, add, etc Alexandr Miloslavskiy
2019-07-31 17:15 ` Junio C Hamano
2019-07-31 17:19 ` Jeff King [this message]
2019-07-31 21:21 ` Junio C Hamano
2019-08-01 13:25 ` Alexandr Miloslavskiy
2019-08-01 17:35 ` Phillip Wood
2019-08-01 20:26 ` Junio C Hamano
2019-08-01 20:40 ` Alexandr Miloslavskiy
2019-08-02 11:33 ` Johannes Schindelin
2019-08-02 11:45 ` Alexandr Miloslavskiy
2019-08-02 14:48 ` Johannes Schindelin
2019-08-02 14:52 ` Alexandr Miloslavskiy
2019-08-02 11:52 ` Alexandr Miloslavskiy
2019-08-02 14:47 ` Johannes Schindelin
2019-08-02 15:11 ` Alexandr Miloslavskiy
2019-08-01 14:26 ` René Scharfe
2019-08-01 14:33 ` Alexandr Miloslavskiy
2019-08-01 15:56 ` Junio C Hamano
2019-08-01 16:04 ` Alexandr Miloslavskiy
2019-08-01 20:45 ` Junio C Hamano
2019-08-01 20:51 ` Alexandr Miloslavskiy
2019-08-02 11:40 ` Johannes Schindelin
2019-08-02 11:44 ` Alexandr Miloslavskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731171956.GA26746@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).