git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Ibrahim El Rhezzali <ibrahim.elrhezzali@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] Improved git signing interface
Date: Tue, 30 Jul 2019 02:59:49 -0400	[thread overview]
Message-ID: <20190730065949.GB4901@sigill.intra.peff.net> (raw)
In-Reply-To: <CACi-FhDeAZecXSM36zroty6kpf2BCWLS=0R+dUwuB96LqFKuTA@mail.gmail.com>

On Mon, Jul 22, 2019 at 04:16:15PM +0200, Ibrahim El Rhezzali wrote:

> I have been selected by the Linux Foundation to work on a summer
> project. I would like to abstract the git signing interface and add
> support for signatures using decentralized identifiers (DID).
> Decentralized identifiers are an emerging standard [0] that allows
> individuals to control their own digital identities, and is often
> called self-sovereign identity (SSI). The SSIMeetup is a good place to
> learn more about SSI [1] and DIDs [2].
> 
> The project’s current goal is to abstract the current GPG interface
> into a more ‘generic’ API that supports the existing OpenPGP and X.509
> functionality while creating the ability to write additional signature
> drivers.

Neat. I'm always wary of supporting "emerging standards", because
sometimes they turn out not to emerge and you are left with historical
cruft. :) But if your changes to Git are mostly around making the
signing config more generic, I think that is something people are
interested in (signify has come up as a possibility before).

You might find this discussion interesting (that patch and the
sub-thread):

 https://public-inbox.org/git/20180409204129.43537-9-mastahyeti@gmail.com/

One of the points I think people didn't like was how Git would detect
signatures embedded in objects (i.e., is matching PEM-like lines enough,
or what would other signing systems want?).

That patch was later dropped in favor of the work from Henning Schild:

  https://public-inbox.org/git/cover.1531208187.git.henning.schild@siemens.com/

which is much more geared at just adding gpgsm support. There were
various discussions about how it could eventually be extended to new
formats. I skimmed over the documentation from your branch and it looks
like a pretty sane layout, with backwards compatibility.

> I have implemented a prototype that works and passes all tests, and in
> the coming weeks I plan to submit a series of patches for your review.
> I first need to clean up the Git history to make it easy to follow. I
> will also ensure that people using the current approach to GPG signing
> can use the proposed approach with only minor changes. The flag
> “--gpg-sign” would evolve to “---sign”, though I would like to
> preserve an alias to the old flag if possible.

Yes, this must not be "minor changes" but "no changes" to be accepted.
It's OK to deprecate things, but old options cannot immediately stop
working. From this email and looking at your config patches, it looks
like that's the route you plan to take. Good.

I look forward to seeing the cleaned-up patches. :)

-Peff

  reply	other threads:[~2019-07-30  6:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:16 [RFC] Improved git signing interface Ibrahim El Rhezzali
2019-07-30  6:59 ` Jeff King [this message]
2019-08-14  8:48   ` Ibrahim El Rhezzali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730065949.GB4901@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=ibrahim.elrhezzali@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).