From: Jonathan Tan <jonathantanmy@google.com>
To: steadmon@google.com
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] submodule: plumb --filter to cloned submodules
Date: Wed, 24 Jul 2019 15:18:15 -0700 [thread overview]
Message-ID: <20190724221815.187788-1-jonathantanmy@google.com> (raw)
In-Reply-To: <52bf9d45b8e2b72ff32aa773f2415bf7b2b86da2.1563322192.git.steadmon@google.com>
> When cloning a repo with a --filter and with --recurse-submodules
> enabled, the partial clone filter only applies to the top-level repo.
> This can lead to unexpected bandwidth and disk usage for projects which
> include large submodules.
>
> Fix this by plumbing the --filter argument from git-clone through
> git-submodule and git-submodule--helper.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
Sorry for not catching this earlier. The cloning itself might work, but
I don't think we support partial-clone submodules right now. In
particular, anything that operates on submodules in-process like grep
(which either adds submodule objects as alternates or calls the
object-loading functions using a different struct repo) will not work,
because we only support lazy loading on the_repository. So if we want
this feature, there is some other work that we will need to do first.
prev parent reply other threads:[~2019-07-24 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 0:11 [PATCH] submodule: plumb --filter to cloned submodules Josh Steadmon
2019-07-24 22:18 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724221815.187788-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).