From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] clean: show an error message when the path is too long
Date: Tue, 16 Jul 2019 18:13:51 +0200 [thread overview]
Message-ID: <20190716161351.GH20404@szeder.dev> (raw)
In-Reply-To: <36677556a26cca9eafd859c88aa9b2c5a6cde309.1563285862.git.gitgitgadget@gmail.com>
On Tue, Jul 16, 2019 at 07:04:23AM -0700, Johannes Schindelin via GitGitGadget wrote:
> +test_expect_success MINGW 'handle clean & core.longpaths = false nicely' '
> + git config core.longpaths false &&
> + test_when_finished git config --unset core.longpaths &&
'test_config core.longpaths false' could replace the above two lines
with a single one.
> + a50=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
> + mkdir -p $a50$a50/$a50$a50/$a50$a50 &&
> + touch $a50$a50/test.txt &&
> + touch $a50$a50/$a50$a50/$a50$a50/test.txt &&
Is there a reason for using 'touch' to create these files here,
instead of the usual '>"$file"' shell redirections? Something
Windows/MinGW/long path specific, perhaps?
> + test_must_fail git clean -xdf 2>.git/err &&
I was puzzled when I saw that '2>.git/err' first, because why put that
file in the .git directory?! but of course 'git clean' would delete
that file if it were in the worktree. OK.
> + grep "too long" .git/err
> +'
> +
> test_done
> --
> gitgitgadget
next prev parent reply other threads:[~2019-07-16 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 14:04 [PATCH 0/1] Show an error if too-long paths are seen by git clean -dfx Johannes Schindelin via GitGitGadget
2019-07-16 14:04 ` [PATCH 1/1] clean: show an error message when the path is too long Johannes Schindelin via GitGitGadget
2019-07-16 15:01 ` René Scharfe
2019-07-16 19:56 ` Junio C Hamano
2019-07-17 18:50 ` Junio C Hamano
2019-07-18 8:49 ` Johannes Schindelin
2019-07-16 16:13 ` SZEDER Gábor [this message]
2019-07-18 9:30 ` [PATCH v2 0/1] Show an error if too-long paths are seen by git clean -dfx Johannes Schindelin via GitGitGadget
2019-07-18 9:30 ` [PATCH v2 1/1] clean: show an error message when the path is too long Johannes Schindelin via GitGitGadget
2019-07-18 16:03 ` Junio C Hamano
2019-07-19 12:53 ` Johannes Schindelin
2019-07-19 15:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716161351.GH20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).