From: Rohit Ashiwal <rohit.ashiwal265@gmail.com> To: git@vger.kernel.org, gitster@pobox.com Cc: phillip.wood123@gmail.com, martin.agren@gmail.com, Johannes.Schindelin@gmx.de, newren@gmail.com, t.gummerer@gmail.com, Rohit Ashiwal <rohit.ashiwal265@gmail.com> Subject: [GSoC][PATCH 1/2] sequencer: add NULL checks under read_author_script Date: Sat, 13 Jul 2019 00:23:56 +0530 Message-ID: <20190712185357.21211-2-rohit.ashiwal265@gmail.com> (raw) In-Reply-To: <20190712185015.20585-1-rohit.ashiwal265@gmail.com> read_author_script reads name, email and author date from the author script. However, it does not check if the arguments are NULL. Adding NULL checks will allow us to selectively get the required value, for example: char *date; if (read_author_script(_path_, NULL, NULL, &date, _int_)) die(_("failed to read author date")); /* needs to be free()'d */ return date; Add NULL checks for better control over the information retrieved. Signed-off-by: Rohit Ashiwal <rohit.ashiwal265@gmail.com> --- sequencer.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/sequencer.c b/sequencer.c index f88a97fb1..a2d7b0925 100644 --- a/sequencer.c +++ b/sequencer.c @@ -821,9 +821,19 @@ int read_author_script(const char *path, char **name, char **email, char **date, error(_("missing 'GIT_AUTHOR_DATE'")); if (date_i < 0 || email_i < 0 || date_i < 0 || err) goto finish; - *name = kv.items[name_i].util; - *email = kv.items[email_i].util; - *date = kv.items[date_i].util; + + if (name) + *name = kv.items[name_i].util; + else + free(kv.items[name_i].util); + if (email) + *email = kv.items[email_i].util; + else + free(kv.items[email_i].util); + if (date) + *date = kv.items[date_i].util; + else + free(kv.items[date_i].util); retval = 0; finish: string_list_clear(&kv, !!retval); -- 2.21.0
next prev parent reply other threads:[~2019-07-12 18:56 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 18:50 [GSoC][PATCH 0/1] rebase -i: support --ignore-whitespace Rohit Ashiwal 2019-07-12 18:50 ` [GSoC][PATCH 1/1] rebase -i: add --ignore-whitespace flag Rohit Ashiwal 2019-07-15 17:57 ` Junio C Hamano 2019-07-15 22:00 ` Rohit Ashiwal 2019-07-15 22:08 ` Junio C Hamano 2019-07-15 22:42 ` Rohit Ashiwal 2019-07-12 18:53 ` [GSoC][PATCH 0/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 " Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 1/2] sequencer: add NULL checks under read_author_script Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 2/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-19 22:36 ` Junio C Hamano 2019-08-02 20:57 ` Rohit Ashiwal 2019-07-20 14:56 ` Phillip Wood 2019-07-23 19:57 ` Rohit Ashiwal 2019-07-24 13:33 ` Phillip Wood 2019-07-19 21:26 ` [GSoC][PATCH v2 0/2] " Junio C Hamano 2019-07-19 21:47 ` Junio C Hamano 2019-07-12 18:53 ` Rohit Ashiwal [this message] 2019-07-15 18:04 ` [GSoC][PATCH 1/2] sequencer: add NULL checks under read_author_script Junio C Hamano 2019-07-12 18:53 ` [GSoC][PATCH 2/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-14 11:31 ` Rohit Ashiwal 2019-07-18 18:55 ` [GSoC][PATCH v2 0/1] rebase -i: support --ignore-whitespace Rohit Ashiwal 2019-07-18 18:55 ` [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag Rohit Ashiwal 2019-07-19 21:33 ` Junio C Hamano 2019-07-23 19:59 ` Rohit Ashiwal 2019-07-23 20:57 ` Junio C Hamano 2019-07-22 10:00 ` Phillip Wood 2019-07-23 19:58 ` Rohit Ashiwal 2019-07-23 21:01 ` Elijah Newren 2019-07-24 11:14 ` Johannes Schindelin 2019-07-24 21:18 ` [GSoC][PATCH v3 0/1] " Rohit Ashiwal 2019-07-24 21:18 ` [GSoC][PATCH v3 1/1] " Rohit Ashiwal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190712185357.21211-2-rohit.ashiwal265@gmail.com \ --to=rohit.ashiwal265@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=martin.agren@gmail.com \ --cc=newren@gmail.com \ --cc=phillip.wood123@gmail.com \ --cc=t.gummerer@gmail.com \ --subject='Re: [GSoC][PATCH 1/2] sequencer: add NULL checks under read_author_script' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git