From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin" <johannes.schindelin@gmx.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Taylor Blau" <me@ttaylorr.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: [PATCH v1.1] ci/lib.sh: update a comment about installed P4 and Git-LFS versions
Date: Sat, 6 Jul 2019 18:21:14 +0200 [thread overview]
Message-ID: <20190706162114.21169-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20190706161648.20836-1-szeder.dev@gmail.com>
A comment in 'ci/lib.sh' claims that the "OS X build installs the
latest available versions" of P4 and Git-LFS, but since 02373e56bd
(ci: don't update Homebrew, 2019-07-03) that's no longer the case, as
it will install the versions which were recorded in the image's
Homebrew database when the image was created.
Update this comment accordingly.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
Sigh... Same patch as before, but corrected a grammar error in the
commit message.
ci/lib.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ci/lib.sh b/ci/lib.sh
index 288a5b3884..0c7171a173 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -163,8 +163,10 @@ linux-clang|linux-gcc)
export GIT_TEST_HTTPD=YesPlease
# The Linux build installs the defined dependency versions below.
- # The OS X build installs the latest available versions. Keep that
- # in mind when you encounter a broken OS X build!
+ # The OS X build installs much more recent versions, whichever
+ # were recorded in the Homebrew database upon creating the OS X
+ # image.
+ # Keep that in mind when you encounter a broken OS X build!
export LINUX_P4_VERSION="16.2"
export LINUX_GIT_LFS_VERSION="1.5.2"
--
2.22.0.667.g5c3548c1fe
next prev parent reply other threads:[~2019-07-06 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 19:32 Travis not looking so good Johannes Schindelin
2019-06-01 0:41 ` brian m. carlson
2019-06-02 11:22 ` SZEDER Gábor
2019-06-26 20:35 ` Taylor Blau
2019-06-27 13:23 ` SZEDER Gábor
2019-06-27 16:46 ` Junio C Hamano
2019-06-29 17:01 ` SZEDER Gábor
2019-07-03 10:47 ` [PATCH 1/2] ci: don't update Homebrew SZEDER Gábor
2019-07-03 10:47 ` [PATCH 2/2] ci: disable Homebrew's auto cleanup SZEDER Gábor
2019-07-03 11:49 ` Johannes Schindelin
2019-07-03 12:26 ` Thomas Braun
2019-07-03 13:04 ` SZEDER Gábor
2019-07-03 16:58 ` Junio C Hamano
2019-07-06 16:16 ` [PATCH] ci/lib.sh: update a comment about installed P4 and Git-LFS versions SZEDER Gábor
2019-07-06 16:21 ` SZEDER Gábor [this message]
2019-07-08 10:00 ` [PATCH v1.1] " Johannes Schindelin
2019-07-09 16:32 ` [PATCH 1/2] ci: don't update Homebrew Taylor Blau
2019-07-10 22:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190706162114.21169-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).