From: Mike Hommey <mh@glandium.org>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org
Subject: Re: Surprising use of memory and time when repacking mozilla's gecko repository
Date: Thu, 4 Jul 2019 22:13:20 +0900 [thread overview]
Message-ID: <20190704131320.ksustvlayy6lby23@glandium.org> (raw)
In-Reply-To: <20190704120411.2dlzdlsooob4dc7k@dcvr>
On Thu, Jul 04, 2019 at 12:04:11PM +0000, Eric Wong wrote:
> Mike Hommey <mh@glandium.org> wrote:
> > I'm puzzled by the fact writing objects is so much faster with 1 thread.
>
> I/O contention in the multi-threaded cases?
>
> "public-inbox-index" (reading from git, writing to Xapian+SQLite)
> on a dev machine got slow because core count exceeded what SATA
> could handle and had to cap the default Xapian shard count to 3
> by default for v2 inboxes.
AFAICT, git doesn't write from multiple threads.
> As for memory use, does git use the producer/consumer pattern
> for malloc+free so free happens in a different thread from the
> malloc?
>
> Because current versions of glibc gets pathological with that case
> (but I have a long-term fix for it):
>
> https://public-inbox.org/libc-alpha/20180731084936.g4yw6wnvt677miti@dcvr/T/
> Only locklessinc malloc seemed OK in the IPC department
> (But I haven't kept up with jemalloc, tcmalloc developments in years)
Oh right, I forgot to mention:
- I thought this memory usage thing was [1] but it turns out it was real
memory usage.
- glibc's mallinfo stores values as int, so it's useless to know how
much memory was allocated when it's more than 4GB.
- glibc's malloc_stats relies on the same int data, so while it does
print "in use" data, it can't print values above 4GB correctly.
- glibc has a malloc_stats function that, according to its manual page
"addresses the deficiencies in malloc_stats and mallinfo", but while
it outputs a large XML dump, it doesn't contain anything that looks
remotely like the "in use" from malloc_stats.
- So all in all, I used jemalloc to gather the "allocated" stats.
Mike
1. https://sourceware.org/bugzilla/show_bug.cgi?id=23416
next prev parent reply other threads:[~2019-07-04 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 10:05 Surprising use of memory and time when repacking mozilla's gecko repository Mike Hommey
2019-07-04 12:04 ` Eric Wong
2019-07-04 13:13 ` Mike Hommey [this message]
2019-07-05 5:14 ` Jeff King
2019-07-05 5:47 ` Mike Hommey
2019-07-05 11:29 ` Jakub Narebski
2019-07-05 0:22 ` Mike Hommey
2019-07-05 4:45 ` Mike Hommey
2019-07-05 5:09 ` Jeff King
2019-07-05 5:45 ` Mike Hommey
2019-07-05 11:51 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704131320.ksustvlayy6lby23@glandium.org \
--to=mh@glandium.org \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).