From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 491851F461 for ; Mon, 1 Jul 2019 12:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727645AbfGAM7s (ORCPT ); Mon, 1 Jul 2019 08:59:48 -0400 Received: from cloud.peff.net ([104.130.231.41]:55862 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727306AbfGAM7s (ORCPT ); Mon, 1 Jul 2019 08:59:48 -0400 Received: (qmail 26000 invoked by uid 109); 1 Jul 2019 12:59:47 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 01 Jul 2019 12:59:47 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 4187 invoked by uid 111); 1 Jul 2019 13:00:40 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 01 Jul 2019 09:00:40 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 01 Jul 2019 08:59:46 -0400 Date: Mon, 1 Jul 2019 08:59:46 -0400 From: Jeff King To: Derrick Stolee Cc: git@vger.kernel.org, Taylor Blau Subject: Re: [PATCH] check_everything_connected: assume alternate ref tips are valid Message-ID: <20190701125945.GB4704@sigill.intra.peff.net> References: <20190628101131.GA22862@sigill.intra.peff.net> <601d8561-6e24-559c-6fbb-fa25a7389fa0@gmail.com> <20190629074348.GA5080@sigill.intra.peff.net> <418213f2-82d6-f7bd-7379-7f20f0e83084@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <418213f2-82d6-f7bd-7379-7f20f0e83084@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jul 01, 2019 at 08:25:09AM -0400, Derrick Stolee wrote: > > I'm not sure what you have in mind, exactly. If you are asking whether > > there are more places that alternate refs could be used, I can't think > > of any. If you are asking whether this is in the wrong place, no, I > > think it's the right place. :) > > Just double-checking that it is appropriate for revision.c to take > dependence on transport.h instead of moving the alternate ref stuff > into a different header file. I trust your opinion. Ah, I see. I misunderstood you before. Yes, this is weakening the ties of the feature to the transport code. Traditionally transport-oriented code was the only user, but it also used the upload-pack transport under the hood to access the alternate (that was changed a while ago to for-each-ref for speed). I don't think there's any functional difference in having it there, but it could be moved to live alongside foreach_alt_odb() in sha1-file.c. -Peff