From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Barret Rhoden <brho@google.com>
Cc: git@vger.kernel.org, "Michael Platings" <michael@platin.gs>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"David Kastrup" <dak@gnu.org>, "Jeff King" <peff@peff.net>,
"Jeff Smith" <whydoubt@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <l.s.r@web.de>,
"Stefan Beller" <stefanbeller@gmail.com>
Subject: Re: [PATCH v9 7/9] blame: add a fingerprint heuristic to match ignored lines
Date: Sat, 29 Jun 2019 19:19:54 +0200 [thread overview]
Message-ID: <20190629171954.GG21574@szeder.dev> (raw)
In-Reply-To: <20190620163820.231316-8-brho@google.com>
On Thu, Jun 20, 2019 at 12:38:18PM -0400, Barret Rhoden wrote:
> diff --git a/t/t8014-blame-ignore-fuzzy.sh b/t/t8014-blame-ignore-fuzzy.sh
> new file mode 100755
> index 000000000000..844396615271
> --- /dev/null
> +++ b/t/t8014-blame-ignore-fuzzy.sh
> @@ -0,0 +1,440 @@
> +test_expect_success setup '
> + { for i in $(test_seq 2 $last_test)
> + do
> + # Append each line in a separate commit to make it easy to
> + # check which original line the blame output relates to.
> +
> + line_count=0 &&
> + { while IFS= read line
> + do
> + line_count=$((line_count+1)) &&
> + echo "$line" >>"$i" &&
> + git add "$i" &&
> + test_tick &&
> + GIT_AUTHOR_NAME="$line_count" git commit -m "$line_count"
> + done } <"a$i"
> + done } &&
> +
> + { for i in $(test_seq 2 $last_test)
> + do
> + # Overwrite the files with the final content.
> + cp b$i $i &&
> + git add $i
> + done } &&
All three loops above have a pair of {} around them... but why? I
don't think they are are necessary and the test does pass without
them.
next prev parent reply other threads:[~2019-06-29 17:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 16:38 [PATCH v9 0/9] blame: add the ability to ignore commits Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 1/9] fsck: rename and touch up init_skiplist() Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 2/9] Move oidset_parse_file() to oidset.c Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 3/9] blame: use a helper function in blame_chunk() Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 4/9] blame: add the ability to ignore commits and their changes Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 5/9] blame: add config options for the output of ignored or unblamable lines Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 6/9] blame: optionally track line fingerprints during fill_blame_origin() Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 7/9] blame: add a fingerprint heuristic to match ignored lines Barret Rhoden
2019-06-29 17:19 ` SZEDER Gábor [this message]
2019-06-30 18:17 ` [PATCH] t8014: remove unnecessary braces michael
2019-07-01 14:16 ` Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 8/9] blame: use the fingerprint heuristic to match ignored lines Barret Rhoden
2019-06-20 16:38 ` [PATCH v9 9/9] blame: add a test to cover blame_coalesce() Barret Rhoden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629171954.GG21574@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=brho@google.com \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=michael@platin.gs \
--cc=peff@peff.net \
--cc=stefanbeller@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).