From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 540281F461 for ; Fri, 28 Jun 2019 09:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726590AbfF1Jjo (ORCPT ); Fri, 28 Jun 2019 05:39:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:53716 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726385AbfF1Jjo (ORCPT ); Fri, 28 Jun 2019 05:39:44 -0400 Received: (qmail 14455 invoked by uid 109); 28 Jun 2019 09:39:43 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 28 Jun 2019 09:39:43 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16087 invoked by uid 111); 28 Jun 2019 09:40:35 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 28 Jun 2019 05:40:35 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 28 Jun 2019 05:39:42 -0400 Date: Fri, 28 Jun 2019 05:39:42 -0400 From: Jeff King To: Derrick Stolee Cc: Git List Subject: [PATCH 2/6] t5310: increase the number of bitmapped commits Message-ID: <20190628093942.GB27329@sigill.intra.peff.net> References: <20190628093751.GA3569@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190628093751.GA3569@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The bitmap index we compute in t5310 has only 20 commits in it. This gives poor coverage of bitmap_writer_select_commits(), which simply writes a bitmap for everything when there are fewer than 100 commits. Let's bump the number of commits in the test to cover the more complex code paths (this does drop coverage of the individual lines of the trivial path, but the complex path does everything it does and more). Signed-off-by: Jeff King --- t/t5310-pack-bitmaps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh index 3aab7024ca..6640329ebf 100755 --- a/t/t5310-pack-bitmaps.sh +++ b/t/t5310-pack-bitmaps.sh @@ -21,7 +21,7 @@ has_any () { } test_expect_success 'setup repo with moderate-sized history' ' - test_commit_bulk --id=file 10 && + test_commit_bulk --id=file 100 && git checkout -b other HEAD~5 && test_commit_bulk --id=side 10 && git checkout master && -- 2.22.0.768.gd89de1e449