From: Jeff King <peff@peff.net>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] a few more redundant system include cleanups
Date: Wed, 19 Jun 2019 13:48:41 -0400 [thread overview]
Message-ID: <20190619174841.GB27834@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPUEspgRnGd4nT3yd2YTGMt8t4qQ=V3GGNeTih3cmjnZHNextw@mail.gmail.com>
On Wed, Jun 19, 2019 at 02:12:30AM -0700, Carlo Arenas wrote:
> > I did a quick grep for similar cases, and didn't find any that I think
> > would be problematic. There were a few cleanups, below.
>
> would you mind if I add your 2 patches to a series and include that
> missing one?, that way I'll also have a chance to write a better commit
> message from my original change, including the other feedback I got
> as well
That's be fine with me. Thanks.
> PS. is there a recommendation on how to version a patch that move
> into a series that would be preferred?
I think you can just say "v2" on the whole thing, include all three
patches, and then write a note that the series supersedes what I sent.
-Peff
next prev parent reply other threads:[~2019-06-19 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 6:45 [PATCH] xdiff: avoid accidental redefinition of LFS feature in OpenIndiana Carlo Marcelo Arenas Belón
2019-06-18 14:43 ` Johannes Schindelin
2019-06-18 15:53 ` [PATCH 0/2] a few more redundant system include cleanups Jeff King
2019-06-18 15:54 ` [PATCH 1/2] verify-tag: drop signal.h include Jeff King
2019-06-18 15:54 ` [PATCH 2/2] wt-status.h: drop stdio.h include Jeff King
2019-06-19 9:12 ` [PATCH 0/2] a few more redundant system include cleanups Carlo Arenas
2019-06-19 17:48 ` Jeff King [this message]
2019-07-03 18:49 ` Junio C Hamano
2019-07-04 5:11 ` Carlo Arenas
2019-07-28 20:07 ` [PATCH v2 0/5] system header cleanup Carlo Marcelo Arenas Belón
2019-07-28 20:07 ` [PATCH v2 1/5] verify-tag: drop signal.h include Carlo Marcelo Arenas Belón
2019-07-28 20:07 ` [PATCH v2 2/5] wt-status.h: drop stdio.h include Carlo Marcelo Arenas Belón
2019-07-28 20:07 ` [PATCH v2 3/5] xdiff: drop system includes in xutils.c Carlo Marcelo Arenas Belón
2019-07-28 20:07 ` [PATCH v2 4/5] xdiff: remove duplicate headers from xhistogram.c Carlo Marcelo Arenas Belón
2019-07-28 20:07 ` [PATCH v2 5/5] xdiff: remove duplicate headers from xpatience.c Carlo Marcelo Arenas Belón
2019-07-28 22:19 ` [PATCH v2 0/5] system header cleanup Jeff King
2019-07-29 4:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619174841.GB27834@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).