From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 3/4] rebase: fix garbled progress display with '-x'
Date: Mon, 17 Jun 2019 21:25:22 +0200 [thread overview]
Message-ID: <20190617192522.GM31952@szeder.dev> (raw)
In-Reply-To: <20190617191328.GL31952@szeder.dev>
[resend to Matthieu's current email address]
On Mon, Jun 17, 2019 at 09:13:28PM +0200, SZEDER Gábor wrote:
> On Fri, Jun 14, 2019 at 08:42:29PM +0200, Johannes Schindelin wrote:
>
> > The `SHELL` thing here is important, as t/t3404-rebase-interactive.sh sets
> > this to the empty value explicitly:
> >
> > https://github.com/git/git/blob/v2.22.0/t/t3404-rebase-interactive.sh#L63-L68
>
> Hmm, hang on for a sec. Why does it set SHELL to empty?
>
> So t3404 sets SHELL to the empty value since cd035b1cef
> (rebase -i: add exec command to launch a shell command, 2010-08-10),
> and the in-test comment highlighted on the above link says:
>
> # "exec" commands are run with the user shell by default, but this may
> # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
> # to create a file. Unsetting SHELL avoids such non-portable behavior
> # in tests. It must be exported for it to take effect where needed.
> SHELL=
>
> Furthermore, the corresponding documentation added in cd035b1cef
> says the following:
>
> The "exec" command launches the command in a shell (the one specified
> in `$SHELL`, or the default shell if `$SHELL` is not set)
>
> IOW if SHELL is not set/empty, then it will run the default '/bin/sh',
> but who knows what it might be, there's no guarantee that it's a sane
> POSIX shell. That's why we have "Define SHELL_PATH to a POSIX shell
> if your /bin/sh is broken." very near to the top of our Makefile.
>
> So while setting SHELL to the empty value might indeed avoid
> non-portable behavior when the user in general prefers a non-POSIX
> shell, it wouldn't help if '/bin/sh' is broken. For that it should be
> set to $SHELL_PATH (or perhaps $TEST_SHELL_PATH nowadays...).
>
> Though cd035b1cef is now close to 9 years old, plenty of time for
> somebody to run into this issue in the wild and speak up...
>
next prev parent reply other threads:[~2019-06-17 19:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 14:25 [PATCH] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-04-30 22:25 ` Johannes Schindelin
2019-05-01 23:16 ` SZEDER Gábor
2019-05-03 8:41 ` Johannes Schindelin
2019-06-11 12:38 ` SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 0/4] rebase/progress: add and use term_clear_line() SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 1/4] t3404-rebase-interactive: use the 'q_to_cr' helper SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 2/4] pager: add a helper function to clear the last line in the terminal SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 3/4] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-06-11 20:36 ` Junio C Hamano
2019-06-11 21:11 ` SZEDER Gábor
2019-06-12 19:14 ` Johannes Schindelin
2019-06-12 19:41 ` SZEDER Gábor
2019-06-13 7:54 ` Johannes Schindelin
2019-06-14 18:42 ` Johannes Schindelin
2019-06-17 18:40 ` SZEDER Gábor
2019-06-17 19:13 ` SZEDER Gábor
2019-06-17 19:25 ` SZEDER Gábor [this message]
2019-06-24 18:39 ` SZEDER Gábor
2019-06-25 10:08 ` Phillip Wood
2019-06-25 11:31 ` SZEDER Gábor
2019-06-25 13:33 ` Phillip Wood
2019-06-25 18:00 ` Phillip Wood
2019-06-25 11:38 ` Johannes Schindelin
2019-06-25 13:35 ` Phillip Wood
2019-06-11 20:48 ` Junio C Hamano
2019-06-11 23:50 ` SZEDER Gábor
2019-06-12 16:21 ` Junio C Hamano
2019-06-11 13:03 ` [PATCH v2 4/4] progress: use term_clear_line() SZEDER Gábor
2019-06-12 20:00 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 0/5] rebase/progress: add and " SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 1/5] t3404: modernize here doc style SZEDER Gábor
2019-06-25 9:06 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 2/5] t3404: make the 'rebase.missingCommitsCheck=ignore' test more focused SZEDER Gábor
2019-06-25 9:07 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 3/5] pager: add a helper function to clear the last line in the terminal SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 4/5] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-06-27 13:42 ` [PATCH v3.1 " SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 5/5] progress: use term_clear_line() SZEDER Gábor
2019-06-25 9:10 ` Johannes Schindelin
2019-06-25 19:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617192522.GM31952@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).