git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Sam Bazley <sambazley@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: rev-parse --is-bare-repository incorrect when work tree is set
Date: Sat, 15 Jun 2019 10:56:02 +0200	[thread overview]
Message-ID: <20190615085602.GH31952@szeder.dev> (raw)
In-Reply-To: <8ac7a1d8-9185-b527-67f4-d5e25cb3eaf5@fastmail.com>

On Sat, Jun 15, 2019 at 02:59:50AM +0100, Sam Bazley wrote:
> rev-parse --is-bare-repository incorrectly outputs "false" when testing
> a bare repository with the work tree set.
> 
> To reproduce:
> 
> $ git init --bare testbare
> $ git --git-dir=testbare rev-parse --is-bare-repository
> true
> $ git --git-dir=testbare --work-tree=something rev-parse \
> --is-bare-repository
> false
> $ GIT_WORK_TREE=something git --git-dir=testbare rev-parse \
> --is-bare-repository
> false

A bare repository is a repository that doesn't have a worktree, and in
the last two cases you explicitly told git that it should treat
something as a worktree, so it just acted accordingly.


      reply	other threads:[~2019-06-15  8:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15  1:59 rev-parse --is-bare-repository incorrect when work tree is set Sam Bazley
2019-06-15  8:56 ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190615085602.GH31952@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sambazley@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).