From: Emily Shaffer <emilyshaffer@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2] rev-list: teach --oid-only to enable piping
Date: Fri, 14 Jun 2019 16:18:48 -0700 [thread overview]
Message-ID: <20190614231848.GE233791@google.com> (raw)
In-Reply-To: <xmqqlfy3ud60.fsf@gitster-ct.c.googlers.com>
On Fri, Jun 14, 2019 at 01:25:59PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > But I wonder if things would be simpler if we did not touch the commit
> > code path at all. I.e., if this were simply "--no-object-names", and it
> > touched only show_object().
>
> Yeah, that sounds more tempting. And the refined code structure you
> suggested ...
>
> >> @@ -255,6 +262,10 @@ static void show_object(struct object *obj, const char *name, void *cb_data)
> >> display_progress(progress, ++progress_counter);
> >> if (info->flags & REV_LIST_QUIET)
> >> return;
> >> + if (arg_oid_only) {
> >> + printf("%s\n", oid_to_hex(&obj->oid));
> >> + return;
> >> + }
> >> show_object_with_name(stdout, obj, name);
> >> }
> >>
> >
> > A minor style point, but I think this might be easier to follow without
> > the early return, since we are really choosing to do A or B. Writing:
> >
> > if (arg_oid_only)
> > printf(...);
> > else
> > show_object_with_name(...);
> >
> > shows that more clearly, I think.
>
> ... is a good way to clearly show that intention, I would think.
Sounds good. Thanks, both; I'll reroll that quickly today.
next prev parent reply other threads:[~2019-06-14 23:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 22:59 [PATCH] revision: remove stray whitespace when name empty Emily Shaffer
2019-06-08 0:42 ` Eric Sunshine
2019-06-12 19:23 ` Emily Shaffer
2019-06-09 13:00 ` Jeff King
2019-06-10 16:29 ` Junio C Hamano
2019-06-12 19:37 ` Emily Shaffer
2019-06-13 15:20 ` Jeff King
2019-06-13 21:51 ` [PATCH v2] rev-list: teach --oid-only to enable piping Emily Shaffer
2019-06-14 16:07 ` Jeff King
2019-06-14 20:25 ` Junio C Hamano
2019-06-14 23:18 ` Emily Shaffer [this message]
2019-06-14 23:29 ` Emily Shaffer
2019-06-19 21:24 ` Jeff King
2019-06-14 23:48 ` [PATCH v3] rev-list: teach --no-object-names " Emily Shaffer
2019-06-17 22:32 ` Junio C Hamano
2019-06-18 22:08 ` Emily Shaffer
2019-06-18 22:29 ` [PATCH v4] " Emily Shaffer
2019-06-19 14:08 ` Junio C Hamano
2019-06-19 19:31 ` Emily Shaffer
2019-06-19 21:30 ` Jeff King
2019-06-19 20:56 ` [PATCH v5] " Emily Shaffer
2019-06-19 21:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614231848.GE233791@google.com \
--to=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).