* git receive-pack deletes refs one at a time?
@ 2019-06-13 17:33 Nasser Grainawi
2019-06-13 17:43 ` Jeff King
0 siblings, 1 reply; 4+ messages in thread
From: Nasser Grainawi @ 2019-06-13 17:33 UTC (permalink / raw)
To: git
I have a situation where I need to delete 100k+ refs on 15+ separate hosts/disks. This setup is using Gerrit replication, so I can trigger it all on one host and it will push the deletes to the rest (all running git-daemon v2.18.0 with receive-pack enabled). All the refs being deleted on the receiving ends are packed.
What I see is the packed-refs file getting locked/updated over and over for each ref. I had assumed it would do something more like 'update-ref --stdin' and do a bulk removal of refs. Am I seeing the correct behavior? If yes, is there a specific reason it works this way or is "bulk delete through push" just a feature that hasn't been implemented yet?
Thanks,
Nasser
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: git receive-pack deletes refs one at a time?
2019-06-13 17:33 git receive-pack deletes refs one at a time? Nasser Grainawi
@ 2019-06-13 17:43 ` Jeff King
2019-06-13 19:46 ` Nasser Grainawi
0 siblings, 1 reply; 4+ messages in thread
From: Jeff King @ 2019-06-13 17:43 UTC (permalink / raw)
To: Nasser Grainawi; +Cc: git
On Thu, Jun 13, 2019 at 11:33:40AM -0600, Nasser Grainawi wrote:
> I have a situation where I need to delete 100k+ refs on 15+ separate
> hosts/disks. This setup is using Gerrit replication, so I can trigger
> it all on one host and it will push the deletes to the rest (all
> running git-daemon v2.18.0 with receive-pack enabled). All the refs
> being deleted on the receiving ends are packed.
>
> What I see is the packed-refs file getting locked/updated over and
> over for each ref. I had assumed it would do something more like
> 'update-ref --stdin' and do a bulk removal of refs. Am I seeing the
> correct behavior? If yes, is there a specific reason it works this way
> or is "bulk delete through push" just a feature that hasn't been
> implemented yet?
The underlying ref code is smart enough to coalesce all of the deletions
in a single transaction into a single write of the packed-refs file.
But historically, pushes do not do a single ref transaction because we
would allow the push for one ref to succeed while others failed. Later,
we added an "atomic" mode that does it all in a single transaction.
Try with "git push --atomic", which should be able to do it in a single
write.
-Peff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: git receive-pack deletes refs one at a time?
2019-06-13 17:43 ` Jeff King
@ 2019-06-13 19:46 ` Nasser Grainawi
2019-06-13 21:20 ` Jeff King
0 siblings, 1 reply; 4+ messages in thread
From: Nasser Grainawi @ 2019-06-13 19:46 UTC (permalink / raw)
To: Jeff King; +Cc: git
> On Jun 13, 2019, at 11:43 AM, Jeff King <peff@peff.net> wrote:
>
> On Thu, Jun 13, 2019 at 11:33:40AM -0600, Nasser Grainawi wrote:
>
>> I have a situation where I need to delete 100k+ refs on 15+ separate
>> hosts/disks. This setup is using Gerrit replication, so I can trigger
>> it all on one host and it will push the deletes to the rest (all
>> running git-daemon v2.18.0 with receive-pack enabled). All the refs
>> being deleted on the receiving ends are packed.
>>
>> What I see is the packed-refs file getting locked/updated over and
>> over for each ref. I had assumed it would do something more like
>> 'update-ref --stdin' and do a bulk removal of refs. Am I seeing the
>> correct behavior? If yes, is there a specific reason it works this way
>> or is "bulk delete through push" just a feature that hasn't been
>> implemented yet?
>
> The underlying ref code is smart enough to coalesce all of the deletions
> in a single transaction into a single write of the packed-refs file.
>
> But historically, pushes do not do a single ref transaction because we
> would allow the push for one ref to succeed while others failed. Later,
> we added an "atomic" mode that does it all in a single transaction.
>
> Try with "git push --atomic", which should be able to do it in a single
> write.
Thanks!
Is there a way to get the bulk behavior without the all-or-nothing behavior?
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: git receive-pack deletes refs one at a time?
2019-06-13 19:46 ` Nasser Grainawi
@ 2019-06-13 21:20 ` Jeff King
0 siblings, 0 replies; 4+ messages in thread
From: Jeff King @ 2019-06-13 21:20 UTC (permalink / raw)
To: Nasser Grainawi; +Cc: git
On Thu, Jun 13, 2019 at 01:46:05PM -0600, Nasser Grainawi wrote:
> > The underlying ref code is smart enough to coalesce all of the deletions
> > in a single transaction into a single write of the packed-refs file.
> >
> > But historically, pushes do not do a single ref transaction because we
> > would allow the push for one ref to succeed while others failed. Later,
> > we added an "atomic" mode that does it all in a single transaction.
> >
> > Try with "git push --atomic", which should be able to do it in a single
> > write.
>
> Thanks!
>
> Is there a way to get the bulk behavior without the all-or-nothing behavior?
No, I don't think so. In theory the ref backend code could have a
"non-atomic" flag that lets it do as much as possible of a single
transaction. But nobody has ever implemented that.
In practice, using "--atomic" shouldn't cause failures, unless you are
trying to delete refs that somebody else is modifying at the same time.
-Peff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-13 21:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 17:33 git receive-pack deletes refs one at a time? Nasser Grainawi
2019-06-13 17:43 ` Jeff King
2019-06-13 19:46 ` Nasser Grainawi
2019-06-13 21:20 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).