From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Christian Couder" <christian.couder@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Brandon Williams" <bmwill@google.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 2/3] t: add t0016-oidmap.sh
Date: Thu, 13 Jun 2019 19:52:36 +0200 [thread overview]
Message-ID: <20190613175236.GF31952@szeder.dev> (raw)
In-Reply-To: <20190613171913.GA14055@sigill.intra.peff.net>
On Thu, Jun 13, 2019 at 01:19:13PM -0400, Jeff King wrote:
> On Sun, Jun 09, 2019 at 11:22:59AM +0200, SZEDER Gábor wrote:
>
> > So, 'test oidmap' from the previous patch prints the value we want to
> > check with:
> >
> > printf("%u\n", sha1hash(oid.hash));
> >
> > First, since object ids inherently make more sense as hex values, it
> > would be more appropriate to print that hash with the '%x' format
> > specifier, and then we wouldn't need Perl's hex() anymore, and thus
> > could swap the order of the first four bytes in oidmap's hash without
> > relying on Perl, e.g. with:
> >
> > sed -e 's/^\(..\)\(..\)\(..\)\(..\).*/\4\3\2\1/'
> >
> > Second, and more importantly, the need for swapping the byte order
> > indicates that this test would fail on big-endian systems, I'm afraid.
> > So I think we need an additional bswap32() on the printing side, and
> > then could further simplify 'test_oidhash':
>
> I agree with all your points about using hex and pushing the logic into
> test-oidmap.c. BUT.
>
> At the point where we are normalizing byte order of the hashes, I have
> to wonder: why do we care about testing the hash value in the first
> place? We care that oidmap can store and retrieve values, and that it
> performs well. But as long as it does those things, I don't think
> anybody cares if it uses the first 4 bytes of the sha1 or the last 4.
>
> I know there are testing philosophies that go to this level of
> white-box testing, but I don't think we usually do in Git. A unit
> test of oidmap's externally visible behavior seems like the right
> level to me.
That's a good point... but then why does 't0011-hashmap.sh' do it in
the first place? As far as I understood this t0016 mainly follows
suit of t0011.
next prev parent reply other threads:[~2019-06-13 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 4:49 [PATCH 0/3] Test oidmap Christian Couder
2019-06-09 4:49 ` [PATCH 1/3] t/helper: add test-oidmap.c Christian Couder
2019-06-09 4:49 ` [PATCH 2/3] t: add t0016-oidmap.sh Christian Couder
2019-06-09 9:22 ` SZEDER Gábor
2019-06-09 20:24 ` Christian Couder
2019-06-09 21:21 ` SZEDER Gábor
2019-06-09 21:51 ` Christian Couder
2019-06-10 16:46 ` Junio C Hamano
2019-06-13 17:19 ` Jeff King
2019-06-13 17:52 ` SZEDER Gábor [this message]
2019-06-13 19:02 ` Jeff King
2019-06-13 22:22 ` Junio C Hamano
2019-06-14 10:36 ` Christian Couder
2019-06-09 4:49 ` [PATCH 3/3] oidmap: use sha1hash() instead of static hash() function Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613175236.GF31952@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).