From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] ci: split the `linux-gcc` job into two jobs
Date: Thu, 13 Jun 2019 19:43:29 +0200 [thread overview]
Message-ID: <20190613174329.GE31952@szeder.dev> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1906131844440.44@tvgsbejvaqbjf.bet>
On Thu, Jun 13, 2019 at 06:51:04PM +0200, Johannes Schindelin wrote:
> Hi,
>
> On Thu, 13 Jun 2019, Junio C Hamano wrote:
>
> > SZEDER Gábor <szeder.dev@gmail.com> writes:
> >
> > > On Thu, Jun 13, 2019 at 05:53:51AM -0700, Johannes Schindelin via GitGitGadget wrote:
> > >> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> > >>
> > >> This job was abused to not only run the test suite in a regular way but
> > >> also with all kinds of `GIT_TEST_*` options set to non-default values.
> > >>
> > >> Let's split this into two
> > >
> > > Why...?
> > >
> > >> with the `linux-gcc` job running the default
> > >> test suite, and the newly-introduced `linux-gcc-extra` job running the
> > >> test suite in the "special" ways.
> > >>
> > >> Technically, we would have to build Git only once, but it would not be
> > >> obvious how to teach Travis to transport build artifacts, so we keep it
> > >> simple and just build Git in both jobs.
> >
> > I had the same reaction.
>
> So basically you are saying that the cover letter was the wrong location
> for this:
>
> For people like me, who often look at our CI builds, it is hard to
> tell whether test suite failures in the linux-gcc job stem from
> the first make test run, or from the second one, after setting all
> kinds of GIT_TEST_* variables to non-default values.
Is this really an issue in practice? In my experience there are only
two (and a half) cases:
- if both the 'linux-gcc' and 'linux-clang' build jobs fail, then
it's some sort of a general breakage.
- if only the 'linux-gcc' build job fails, the 'linux-clang'
succeeds, then it's a breakage in the test run with the various
'GIT_TEST_*' test knobs enabled (unless the failing 'linux-gcc'
build job's runtime is below, say, 5 minutes, in which case it's a
build error only triggered by GCC(-8), and, as I recall, is rather
rare).
> Let's make it easier on people like me.
>
> This also helps the problem where the CI builds often finish the other
> jobs waaaay before linux-gcc finally finishes
This is not the case on Travis CI, where the runtime of the macOS
build jobs are far the longest, so this change won't help anything
there... on the contrary, it would make things slower by spending time
on installing dependencies and building Git in one more build job.
> too: linux-gcc and
> linux-gcc-extra can be run in parallel, on different agents.
next prev parent reply other threads:[~2019-06-13 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:53 [PATCH 0/1] ci: split linux-gcc into linux-gcc and linux-gcc-extra Johannes Schindelin via GitGitGadget
2019-06-13 12:53 ` [PATCH 1/1] ci: split the `linux-gcc` job into two jobs Johannes Schindelin via GitGitGadget
2019-06-13 15:33 ` SZEDER Gábor
2019-06-13 15:56 ` Junio C Hamano
2019-06-13 16:51 ` Johannes Schindelin
2019-06-13 17:43 ` SZEDER Gábor [this message]
2019-06-14 19:35 ` Johannes Schindelin
2019-06-25 8:56 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613174329.GE31952@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).