git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jonathan Tan" <jonathantanmy@google.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Christian Couder" <chriscool@tuxfamily.org>
Subject: [PATCH v2 0/3] Test oidmap
Date: Tue, 11 Jun 2019 10:23:22 +0200	[thread overview]
Message-ID: <20190611082325.28878-1-chriscool@tuxfamily.org> (raw)

Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh
oidmap has no specific test. The goal of this small patch series is to
change that and also improve oidmap a bit while at it.

Changes compared to V1 are the following:

  - use printf("%x\n", ntohl(sha1hash(oid.hash))) to print hashes as
    suggested by Gábor and approved by Junio,

  - use `git rev-parse "$1" | cut -c1-8` to check hashes in t0016 as
    suggested by Gábor,

  - removed PERL prereq on "hash" test in t0016 as allowed by the
    above change and suggested by Gábor,

  - removed suprious space between ">" and "expect" in t0016 as
    suggested by Gábor.

I decided against hardcoding values as I think it might help
transitionning from SHA1 to SHA256.

Christian Couder (3):
  t/helper: add test-oidmap.c
  t: add t0016-oidmap.sh
  oidmap: use sha1hash() instead of static hash() function

 Makefile               |   1 +
 oidmap.c               |  13 +---
 t/helper/test-oidmap.c | 134 +++++++++++++++++++++++++++++++++++++++++
 t/helper/test-tool.c   |   1 +
 t/helper/test-tool.h   |   1 +
 t/t0016-oidmap.sh      | 100 ++++++++++++++++++++++++++++++
 6 files changed, 240 insertions(+), 10 deletions(-)
 create mode 100644 t/helper/test-oidmap.c
 create mode 100755 t/t0016-oidmap.sh

-- 
2.22.0.6.gde8b105b43


             reply	other threads:[~2019-06-11  8:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11  8:23 Christian Couder [this message]
2019-06-11  8:23 ` [PATCH v2 1/3] t/helper: add test-oidmap.c Christian Couder
2019-06-11  8:23 ` [PATCH v2 2/3] t: add t0016-oidmap.sh Christian Couder
2019-06-11 10:12   ` SZEDER Gábor
2019-06-12 17:09     ` Christian Couder
2019-06-11  8:23 ` [PATCH v2 3/3] oidmap: use sha1hash() instead of static hash() function Christian Couder
2019-06-11 10:12 ` [PATCH v2 0/3] Test oidmap SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611082325.28878-1-chriscool@tuxfamily.org \
    --to=christian.couder@gmail.com \
    --cc=avarab@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).