From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Derrick Stolee <dstolee@microsoft.com>,
Jeffrey Walton <noloader@gmail.com>
Subject: Re: Git self test failure on Solaris 11.3
Date: Thu, 6 Jun 2019 13:35:17 -0400 [thread overview]
Message-ID: <20190606173516.GA25089@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cS98DeSaF6pNqKCn6bAy=jjiTuc3AZpPB2cXm6hQ6vcqQ@mail.gmail.com>
On Thu, Jun 06, 2019 at 01:18:01PM -0400, Eric Sunshine wrote:
> > > not ok 12 - check normal git operations: twelve packs
> > > #
> > > # midx_git_two_modes "rev-list --objects --all" &&
> > > # midx_git_two_modes "log --raw" &&
> > > # midx_git_two_modes "count-objects --verbose" &&
> > > # midx_git_two_modes "cat-file
> > > --batch-all-objects --buffer --batch-check" &&
> > > # midx_git_two_modes "cat-file
> > > --batch-all-objects --buffer --batch-check --unsorted" sorted
> > > #
> [...]
>
> Jeff Walton reported this to me privately. I'm not familiar with this
> code and don't have time presently to investigate it, so I'm
> forwarding it to the list in the hope that someone who knows the code
> intimately (Stolee) or someone who has touched this code (Peff) might
> have some idea about it. The failure is intermittent, so perhaps the
> output of some command is not stable sort-wise(?).
I can't seem to get it to fail for me, even under high load. Do you know
which of those commands is failing (i.e., what does "-v -x" say)?
If it's the rev-list or log output, it could be due to traversal order.
I notice that the commit creation doesn't increment the timestamps. This
might help:
diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh
index 70926b5bc0..79aa97efce 100755
--- a/t/t5319-multi-pack-index.sh
+++ b/t/t5319-multi-pack-index.sh
@@ -60,6 +60,7 @@ commit_and_list_objects () {
} >file_101 &&
git update-index --add file_101 &&
tree=$(git write-tree) &&
+ test_tick &&
commit=$(git commit-tree $tree -p HEAD</dev/null) &&
{
echo $tree &&
Though I think in each case that the results should be deterministic for
a given set of commits (and the tests here are just running over the
same set of commits with and without midx; so we should see the same
output in both cases).
The normal "cat-file" output should be sorted by sha1, so should be
stable. The unsorted output will be in whatever order we happen to hit
the packfiles, which _would_ be subject to timestamp variations.
However, Jeffrey's email mentions Git 2.21, which predates my b4a14394af
(t5319: fix bogus cat-file argument, 2019-04-05). So before that,
"cat-file --unsorted" should always be producing no output. :)
After the switch to correctly use --unordered, I could believe there
might be a timestamp issue, but the "sorted" flag there means that we
should be sorting the output before comparing.
I can't reproduce the intermittent failure either on 2.21.0, or with
v2.22.0-rc3.
-Peff
next prev parent reply other threads:[~2019-06-06 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAH8yC8kynjwT8wbHYV0DpDaMX=AnfmXeOci3uYUnnfsvbq4iRg@mail.gmail.com>
[not found] ` <CAH8yC8knkXtBii9KhS2iUo908zTx_NyPUgXZhqdwmwEF7Gz8Jg@mail.gmail.com>
2019-06-06 17:18 ` Git self test failure on Solaris 11.3 Eric Sunshine
2019-06-06 17:35 ` Jeff King [this message]
2019-06-06 19:00 ` Eric Sunshine
2019-06-06 19:05 ` Jeff King
2019-06-07 1:03 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606173516.GA25089@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=noloader@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).