git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>,
	Brandon Williams <bmwill@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Stephan Beyer <s-beyer@gmx.net>, Taylor Blau <me@ttaylorr.com>,
	Patryk Obara <patryk.obara@gmail.com>
Subject: Re: [PATCH] clang-format: use git grep to generate the ForEachMacros list
Date: Wed, 5 Jun 2019 13:20:19 -0700	[thread overview]
Message-ID: <20190605202019.GA84760@D-10-18-172-221.dhcp4.washington.edu> (raw)
In-Reply-To: <20190603224814.GA15851@gmail.com>

Hi Miguel,

On Tue, Jun 04, 2019 at 12:48:14AM +0200, Miguel Ojeda wrote:
> The ForEachMacros list can reasonably be generated grepping
> the C source code for macros with 'for_each' in their name.
>
> Taken almost verbatim from the .clang-format file in the Linux kernel.
>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

Thanks for CC-ing me on this. I suspect that it was because I show up
somewhere recently in the blame for 'git grep' (I believe I worked on
adding `-o` about a year ago).

You 'git grep' usage of course looks correct, so this patch looks good
to me, too.

Thanks,
Taylor

  parent reply	other threads:[~2019-06-05 20:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 22:48 [PATCH] clang-format: use git grep to generate the ForEachMacros list Miguel Ojeda
2019-06-04 16:07 ` Johannes Schindelin
2019-06-05 20:20 ` Taylor Blau [this message]
2019-06-06 18:29   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605202019.GA84760@D-10-18-172-221.dhcp4.washington.edu \
    --to=me@ttaylorr.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=jrnieder@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=patryk.obara@gmail.com \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).