On 2019-05-15 at 22:27:56, brian m. carlson wrote: > On Tue, May 14, 2019 at 07:46:17PM +0700, Duy Nguyen wrote: > > 'struct string_list;' should be enough (and a bit lighter) although I > > don't suppose it really matters. > > I can make that change. One thing I noticed when making this change is that we're going to need the definition of the struct string_list in a later patch in the series (originally to define a variable, but now to define a struct). So knowing that, I think it makes sense for us to just include the header up front, since we're going to be using it a few patches later. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204