git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Vanak, Ibrahim" <ibrahim.vanak@hpe.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: GIT issue while cloning (fatal: pack is corrupted (SHA1 mismatch)) !!!
Date: Tue, 28 May 2019 17:30:04 -0400	[thread overview]
Message-ID: <20190528213004.GF24650@sigill.intra.peff.net> (raw)
In-Reply-To: <TU4PR8401MB1216A7B920D40B5063123A94E11E0@TU4PR8401MB1216.NAMPRD84.PROD.OUTLOOK.COM>

On Tue, May 28, 2019 at 06:45:18PM +0000, Vanak, Ibrahim wrote:

> BUT still I have significant slowness(50 times slower than clone on
> linux machine) while cloning. HPUX box is having very good H/W
> configuration and network is also stable.

From your output:

> [hpux]
> Receiving objects: 100% (63627/63627), 681.90 MiB | 111.00 KiB/s, done.
> [linux]
> Receiving objects: 100% (63627/63627), 681.90 MiB | 5.59 MiB/s, done.

The main things going on there are:

  1. we're getting the bytes over the network

  2. we're computing a sha1 on the stream we're getting

  3. we're zlib inflating any non-delta objects we find and computing
     their sha1

  4. we're checking the filesystem to see if we have other copies of any
     of those objects

For (2) and (3) it could be that the sha1 implementation is not quite as
fast. But 50x is much larger than I'd expect. If you've built Git from
source, you could try running "t/helper/test-sha1 <big-file" and timing
the result. That would isolate sha1 performance.  If it's slow, try
building with "make BLK_SHA1=Yes" or "make OPENSSL_SHA1=Yes" and see if
that's faster.

For (4), we'll have to stat() in .git/objects to see if we have a loose
version of the object. That can be slow if you have a really terrible
NFS setup, for example. But I doubt that would still be slow in v2.21.
There we should be using the new loose-cache which will only readdir()
the object directories once.

If neither of those pan out, it seems like the network is slow? Or maybe
ssh? Or pipes passing data from clone to index-pack?

-Peff

  reply	other threads:[~2019-05-28 21:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  9:10 GIT issue while cloning (fatal: pack is corrupted (SHA1 mismatch)) !!! Vanak, Ibrahim
2019-05-28  9:37 ` Jeff King
2019-05-28  9:51   ` Ævar Arnfjörð Bjarmason
2019-05-28 18:45   ` Vanak, Ibrahim
2019-05-28 21:30     ` Jeff King [this message]
2019-05-29  5:29       ` Vanak, Ibrahim
2019-05-29  9:06         ` Vanak, Ibrahim
2019-05-30 11:57           ` Jeff King
2019-06-11 16:39             ` Vanak, Ibrahim
2019-06-18 14:31               ` Vanak, Ibrahim
2019-06-18 17:15                 ` Jeff Hostetler
2019-06-28 16:18                   ` Vanak, Ibrahim
2019-06-28 23:55                     ` Jeff King
2019-05-28 10:16 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528213004.GF24650@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=ibrahim.vanak@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).