From: Todd Zullinger <tmz@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Eric Wong <e@80x24.org>, Chris Mayo <aklhfex@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Dennis Kaarsemaker <dennis@kaarsemaker.net>,
git@vger.kernel.org
Subject: Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL
Date: Mon, 27 May 2019 21:56:22 -0400 [thread overview]
Message-ID: <20190528015621.GZ3654@pobox.com> (raw)
In-Reply-To: <87h89fmjzc.fsf@evledraar.gmail.com>
Hi,
Sorry I missed your earlier reply which also mentioned using
$obj->can() Ævar. That's what I get for typing a reply and
then walking away for a few hours before hitting send. ;)
Ævar Arnfjörð Bjarmason wrote:
> Same, but to bikeshed a bit, at this point we can just do:
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 24859a7bc3..4ad2091a49 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1468 +1467,0 @@ sub send_message {
> - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("2.34");
> @@ -1485 +1484 @@ sub send_message {
> - if ($use_net_smtp_ssl) {
> + if (Net::SMTP->can('starttls')) {
> @@ -1507 +1506 @@ sub send_message {
> - if ($use_net_smtp_ssl) {
> + if (Net::SMTP->can('starttls')) {
>
I think we'd need to use 'if ! ...' there, or more likely,
switch the blocks which follow because the code following
'if ($use_net_smtp_ssl)' is for Net::SMTP::SSL with the
'else' block handling the case where Net::SMTP has ssl/tls
support. Right?
I know I read the $use_net_smtp_ssl bit backwards the first
time or two as well.
--
Todd
next prev parent reply other threads:[~2019-05-28 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 17:22 [PATCH] send-email: remove documented requirement for Net::SMTP::SSL Chris Mayo
2019-05-27 19:35 ` Eric Wong
2019-05-27 20:36 ` Ævar Arnfjörð Bjarmason
2019-05-27 23:43 ` brian m. carlson
2019-05-28 2:17 ` Ævar Arnfjörð Bjarmason
2019-05-28 1:22 ` Eric Wong
2019-05-28 0:05 ` Todd Zullinger
2019-05-28 1:31 ` Eric Wong
2019-05-28 1:43 ` Ævar Arnfjörð Bjarmason
2019-05-28 1:56 ` Todd Zullinger [this message]
2019-05-28 1:57 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528015621.GZ3654@pobox.com \
--to=tmz@pobox.com \
--cc=aklhfex@gmail.com \
--cc=avarab@gmail.com \
--cc=dennis@kaarsemaker.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).