From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 1/1] bundle verify: error out if called without an object database
Date: Mon, 27 May 2019 20:25:28 +0000 [thread overview]
Message-ID: <20190527202528.GG8616@genre.crustytoothpaste.net> (raw)
In-Reply-To: <8467593c158ffac56897cf02e165173d9c0b5880.1558988458.git.gitgitgadget@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 2019-05-27 at 20:21:00, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The deal with bundles is that they really are thin packs, with very
> little sugar on top. So we really need a repository (or more
> appropriately, an object database) to work with, when asked to verify a
> bundle.
>
> Let's error out with a useful error message if `git bundle verify` is
> called without such an object database to work with.
>
> Reported by Konstantin Ryabitsev.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I think this looks great.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
prev parent reply other threads:[~2019-05-27 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 19:59 [PATCH 0/1] bundle verify: improve the user experience when called without a .git/ directory Johannes Schindelin via GitGitGadget
2019-05-27 19:59 ` [PATCH 1/1] bundle verify: error out if called without an object database Johannes Schindelin via GitGitGadget
2019-05-27 20:08 ` brian m. carlson
2019-05-27 20:20 ` Johannes Schindelin
2019-05-28 1:51 ` Jeff King
2019-05-28 11:17 ` Johannes Schindelin
2019-05-28 20:58 ` Jeff King
2019-05-28 20:03 ` Junio C Hamano
2019-05-28 21:04 ` Jeff King
2019-05-28 21:09 ` Junio C Hamano
[not found] ` <pull.226.v2.git.gitgitgadget@gmail.com>
[not found] ` <8467593c158ffac56897cf02e165173d9c0b5880.1558988458.git.gitgitgadget@gmail.com>
2019-05-27 20:25 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527202528.GG8616@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=konstantin@linuxfoundation.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).