From: Matthew DeVore <matvore@comcast.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Jeff Hostetler <jeffhost@microsoft.com>,
Jeff Hostetler <git@jeffhostetler.com>,
Jonathan Tan <jonathantanmy@google.com>,
Matthew DeVore <matvore@google.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [RFC PATCH] list-objects-filter: disable 'sparse:path' filters
Date: Fri, 24 May 2019 10:07:58 -0700 [thread overview]
Message-ID: <20190524170758.GB7160@comcast.net> (raw)
In-Reply-To: <20190524120318.4851-1-chriscool@tuxfamily.org>
On Fri, May 24, 2019 at 02:03:18PM +0200, Christian Couder wrote:
> For now though, let's just disable 'sparse:path' filters.
This is probably the right thing to do. I did jump through a lot of hoops to
support escaping sub-filters in my pending filter combination patchset, since
sparse spec path names can have arbitrary characters. After this patch we only
support a handful of characters in filterspecs, so a lot of that escaping logic
can be dropped, at least for now. Anyway, this is not a complaint, just an
observation.
The alternative is to hide sparse:path= support behind a flag which is disabled
by default, but I don't recommend doing that just to have an excuse to include
the URL-encoding logic.
Thank you for cleaning up.
> } else if (skip_prefix(arg, "sparse:path=", &v0)) {
> - filter_options->choice = LOFC_SPARSE_PATH;
> - filter_options->sparse_path_value = strdup(v0);
> - return 0;
> + if (errbuf) {
> + strbuf_addstr(
> + errbuf,
> + _("sparse:path filters are now disabled"));
This wording may leave room for misunderstanding, since it sounds a little like
the filter can be re-enabled somehow. Maybe you can say "sparse:path filters
support has been dropped [optional: 'for security reasons' etc.]"
> + }
> + return 1;
> }
> /*
> * Please update _git_fetch() in git-completion.bash when you
As the comment states, don't forget to update git-completion.bash :)
next prev parent reply other threads:[~2019-05-24 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 12:03 [RFC PATCH] list-objects-filter: disable 'sparse:path' filters Christian Couder
2019-05-24 12:21 ` Ævar Arnfjörð Bjarmason
2019-05-24 12:39 ` Christian Couder
2019-05-24 18:46 ` Jeff Hostetler
2019-05-28 6:13 ` Jeff King
2019-05-28 13:29 ` Jeff Hostetler
2019-05-24 17:07 ` Matthew DeVore [this message]
2019-05-24 19:43 ` Christian Couder
2019-05-24 19:33 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524170758.GB7160@comcast.net \
--to=matvore@comcast.net \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=matvore@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).