From: "SZEDER Gábor" <email@example.com> To: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> Cc: Derrick Stolee <email@example.com>, Jakub Narebski <firstname.lastname@example.org>, Karl Ostmo <email@example.com>, firstname.lastname@example.org Subject: Re: standalone library/tool to query commit-graph? Date: Fri, 24 May 2019 13:37:10 +0200 [thread overview] Message-ID: <20190524113710.GG951@szeder.dev> (raw) In-Reply-To: <email@example.com> On Fri, May 24, 2019 at 12:49:12PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > On Thu, May 23, 2019 at 07:48:33PM -0400, Derrick Stolee wrote: > >> >> On 5/23/2019 6:20 PM, SZEDER Gábor wrote: > >> >> > On Thu, May 23, 2019 at 11:54:22PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > > >> >> >> and since the commit graph doesn't include any commits outside of > >> >> >> packs you'd miss any loose commits. > >> >> > > >> >> > No, the commit-graph includes loose commits as well. > >> >> > >> >> Depends on how you build the commit-graph. > >> > > >> > Yeah; I just didn't want to go into details, hoping that this short > >> > reply will be enough to jog Ævar's memory to recall our earlier > >> > discussion about this :) > >> > >> To clarify (and I should have said) I meant it'll include only packed > >> commits in the mode Karl Ostmo invoked it in, as Derrick points out. > > > > No, even in that mode it will include loose objects as well, if it has > > to; that's what the "and closes under reachability" part of Derrick's > > reply means and that's what I showed in our earlier discussion at: > > > > https://public-inbox.org/git/20190322154943.GF22459@szeder.dev/ > > I should have said "include any commits outside of packs [to seed the > revision walk]". > > As you correctly point out there *are* caveats to that, e.g. it's > possible to have packs & loose commits but you include everything > because of reachability. > > For the purposes of the discussion Jakub started upthread the > not-quite-correct-but-close-enough mental model that we generally tend > to accumulate loose objects that later coalesce into packs is close > enough. > > I.e. for that reason for most users a "git commit-graph write" won't > produce a graph with all reachable commits, e.g. try cloning git.git, > "git am"-ing a patch on top, and generate it again, it'll be the same > (unless you picked a humongous patch). Ok, with this I finally understand what you meant. And it just reinforces my long-held belief that '--reachable' should be the default for 'git commit-graph write'...
next prev parent reply other threads:[~2019-05-24 11:37 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-22 18:49 Karl Ostmo 2019-05-22 18:59 ` Derrick Stolee 2019-05-23 19:29 ` Jakub Narebski 2019-05-23 21:54 ` Ævar Arnfjörð Bjarmason 2019-05-23 22:20 ` SZEDER Gábor 2019-05-23 23:48 ` Derrick Stolee 2019-05-24 9:34 ` SZEDER Gábor 2019-05-24 9:49 ` Ævar Arnfjörð Bjarmason 2019-05-24 10:06 ` SZEDER Gábor 2019-05-24 10:49 ` Ævar Arnfjörð Bjarmason 2019-05-24 11:37 ` SZEDER Gábor [this message] 2019-06-25 18:27 ` Jakub Narebski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190524113710.GG951@szeder.dev \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: standalone library/tool to query commit-graph?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).