From: Jeff King <peff@peff.net>
To: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git archive generates tar with malformed pax extended attribute
Date: Fri, 24 May 2019 03:06:44 -0400 [thread overview]
Message-ID: <20190524070644.GF25694@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMVcy0Q0TL6uEGR2NeudJrOiXdQ87XcducL0EwMidWucjk5XYw@mail.gmail.com>
On Fri, May 24, 2019 at 08:45:23AM +0200, Keegan Carruthers-Smith wrote:
> git archive can generate a malformed tar archive. bsdtar reports the
> error "tar: Ignoring malformed pax extended attribute" when reading
> the archive. Go's "tar/archive" package also reports the error
> "archive/tar: invalid tar header". However, BusyBox's tar does not
> report the error (unsure if it just has less error logging).
>
> I can reproduce this when generating the tar on linux and mac. I
> tested this with "git version 2.21.0" and a build of next I did today:
> "git version 2.22.0.rc1.257.g3120a18244"
>
> Reproduction:
>
> $ git clone https://github.com/SSW-SCIENTIFIC/NNDD.git
> $ cd NNDD
> $ git archive --format tar c21b98da2ca7f007230e696b2eda5da6589fe137
> | tar tf - > /dev/null
> tar: Ignoring malformed pax extended attribute
> tar: Error exit delayed from previous errors.
I can't reproduce on Linux, using GNU tar (1.30) nor with bsdtar 3.3.3
(from Debian's bsdtar package). What does your "tar --version" say?
Git does write a pax header with the commit id in it as a comment.
Presumably that's what it's complaining about (but it is not malformed
according to any tar I've tried). If you feed git-archive a tree rather
than a commit, that is omitted. What does:
git archive --format tar c21b98da2^{tree} | tar tf - >/dev/null
say? If it doesn't complain, then we know it's indeed the pax comment
field.
-Peff
next prev parent reply other threads:[~2019-05-24 7:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 6:45 git archive generates tar with malformed pax extended attribute Keegan Carruthers-Smith
2019-05-24 7:06 ` Jeff King [this message]
2019-05-24 7:35 ` Keegan Carruthers-Smith
2019-05-24 8:13 ` Jeff King
2019-05-25 13:26 ` René Scharfe
2019-05-25 13:46 ` Andreas Schwab
2019-05-25 21:07 ` Ævar Arnfjörð Bjarmason
2019-05-26 21:33 ` René Scharfe
2019-05-28 5:44 ` Jeff King
2019-05-28 5:58 ` Jeff King
2019-05-28 18:01 ` René Scharfe
2019-05-28 19:08 ` Jeff King
2019-05-28 23:34 ` René Scharfe
2019-05-29 1:17 ` Jeff King
2019-05-29 17:54 ` René Scharfe
2019-05-30 11:55 ` Jeff King
2019-06-02 16:58 ` René Scharfe
2019-06-04 20:53 ` Jeff King
2019-05-27 5:11 ` Keegan Carruthers-Smith
2019-05-25 20:46 ` Ævar Arnfjörð Bjarmason
2019-05-25 21:19 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524070644.GF25694@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=keegan.csmith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).