git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Xin Li <delphij@google.com>
Cc: git@vger.kernel.org, jonathantanmy@google.com,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.
Date: Thu, 23 May 2019 17:01:50 -0700	[thread overview]
Message-ID: <20190524000150.GD70860@google.com> (raw)
In-Reply-To: <20190523235543.4342-1-delphij@google.com>

Xin Li wrote:

> Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value.

Good catch!

Nits:

- s/partialcone/partialclone/ (missing "l")

- subject lines in git.git tend to be of the form
  "subsystem: lowercase summary" with no trailing period.  So maybe
  something like:

	clone: respect user supplied origin name when setting up partial clone

> Signed-off-by: Xin Li <delphij@google.com>
> ---
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The change looks obviously good.  With or without a commit message
change like suggested above,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

  reply	other threads:[~2019-05-24  0:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 23:55 Xin Li
2019-05-24  0:01 ` Jonathan Nieder [this message]
2019-05-24  0:15   ` [PATCH] clone: respect user supplied origin name when setting up partial clone Xin Li
2019-05-29 19:59     ` Junio C Hamano
2019-05-29 21:16       ` [PATCH v3] " Xin Li
2019-05-29 21:22         ` [PATCH v4] " Xin Li
2019-05-29 21:26           ` [PATCH v5] " Xin Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524000150.GD70860@google.com \
    --to=jrnieder@gmail.com \
    --cc=delphij@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --subject='Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).