From: Jonathan Nieder <jrnieder@gmail.com>
To: "Eric S. Raymond" <esr@thyrsus.com>
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: RFC: Separate commit identification from Merkle hashing
Date: Thu, 23 May 2019 13:54:57 -0700 [thread overview]
Message-ID: <20190523205457.GC70860@google.com> (raw)
In-Reply-To: <20190523205009.GA69096@thyrsus.com>
Eric S. Raymond wrote:
> Jakub Narebski <jnareb@gmail.com>:
>> Currently Git makes use of the fact that SHA-1 and SHA-256 identifiers
>> are of different lengths to distinguish them (see section "Meaning of
>> signatures") in Documentation/technical/hash-function-transition.txt
>
> That's the obvious hack. As a future-proofing issue, though, I think
> it would be unwise to count on all future hashes being of distinguishable
> lengths.
We're not counting on that. As discussed in that section, future
hashes can change the format.
[...]
>> All right. Looks sensible on first glance.
>
> I am very relieved to hear that. My view of git is outside-in; I was quite
> worried I might have missed some crucial issue.
Honestly, I do think you have missed some fundamental issues.
https://public-inbox.org/git/ab3222ab-9121-9534-1472-fac790bf08a4@gmail.com/
discusses this further.
Regards,
Jonathan
next prev parent reply other threads:[~2019-05-23 20:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 1:32 RFC: Separate commit identification from Merkle hashing Eric S. Raymond
2019-05-21 1:57 ` Jonathan Nieder
2019-05-21 2:38 ` Eric S. Raymond
2019-05-21 2:58 ` Jonathan Nieder
2019-05-21 3:31 ` Eric S. Raymond
2019-05-23 19:09 ` Jakub Narebski
2019-05-23 20:09 ` Jonathan Nieder
2019-05-23 20:53 ` Eric S. Raymond
2019-05-23 20:50 ` Eric S. Raymond
2019-05-23 20:54 ` Jonathan Nieder [this message]
2019-05-23 21:19 ` Eric S. Raymond
2019-05-23 21:39 ` Randall S. Becker
2019-05-23 21:50 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523205457.GC70860@google.com \
--to=jrnieder@gmail.com \
--cc=esr@thyrsus.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).