From: Jonathan Nieder <jrnieder@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v4] grep: fail if call could output and name is null
Date: Thu, 23 May 2019 13:34:15 -0700 [thread overview]
Message-ID: <20190523203415.GB70860@google.com> (raw)
In-Reply-To: <20190523202355.152742-1-emilyshaffer@google.com>
Emily Shaffer wrote:
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Since v3, only the commit message has changed. Reworked based on
> Jonathan Nieder's suggestions (with some modifications for readability).
>
> grep.c | 4 ++++
> 1 file changed, 4 insertions(+)
This is indeed
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for your patient work.
next prev parent reply other threads:[~2019-05-23 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 2:00 [RFC PATCH] grep: provide sane default to grep_source struct Emily Shaffer
2019-05-16 3:07 ` Junio C Hamano
2019-05-16 3:13 ` Jonathan Nieder
2019-05-16 3:11 ` Jonathan Nieder
2019-05-16 21:05 ` Emily Shaffer
2019-05-16 21:44 ` [PATCH v2] " Emily Shaffer
2019-05-16 22:02 ` Jeff King
2019-05-21 23:52 ` Emily Shaffer
2019-05-22 0:17 ` Jonathan Nieder
2019-05-22 0:34 ` [PATCH v3] " Emily Shaffer
2019-05-22 0:58 ` Jonathan Nieder
2019-05-22 4:01 ` Jeff King
2019-05-23 20:23 ` [PATCH v4] grep: fail if call could output and name is null Emily Shaffer
2019-05-23 20:34 ` Jonathan Nieder [this message]
2019-05-28 17:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523203415.GB70860@google.com \
--to=jrnieder@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).