From: Mike Hommey <mh@glandium.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Closing fds twice when using remote helpers
Date: Thu, 16 May 2019 17:35:19 +0900 [thread overview]
Message-ID: <20190516083519.5n6qmdw2aaqhjudd@glandium.org> (raw)
In-Reply-To: <20190516032802.GB4596@sigill.intra.peff.net>
On Wed, May 15, 2019 at 11:28:02PM -0400, Jeff King wrote:
> Totally orthogonal, but I think we might also want to introduce a helper
> capability so that import helpers can say "I always send 'done' to
> fast-import". And then we can pass "--done" to fast-import, which means
> it would detect a truncated stream.
Doubly orthogonal, but I wouldn't mind a helper capability that allows
import helpers to deal with creating git objects on their own rather
than having a fast-import spawned (git-cinnabar actually doesn't use the
fast-import stream it's offered to use, but can't be a fetch helper
either)
Mike
next prev parent reply other threads:[~2019-05-16 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 10:56 Closing fds twice when using remote helpers Mike Hommey
2019-05-15 11:43 ` Ævar Arnfjörð Bjarmason
2019-05-15 17:59 ` Johannes Sixt
2019-05-15 22:08 ` Mike Hommey
2019-05-15 23:53 ` Jeff King
2019-05-16 0:48 ` Mike Hommey
2019-05-16 3:28 ` Jeff King
2019-05-16 8:35 ` Mike Hommey [this message]
2019-05-16 21:47 ` Jeff King
2019-05-16 22:02 ` Mike Hommey
2019-05-16 0:31 ` Mike Hommey
2019-05-16 0:37 ` [PATCH 1/2] dup() the input fd for fast-import used for " Mike Hommey
2019-05-16 0:37 ` [PATCH 2/2] Use xmmap_gently instead of xmmap in use_pack Mike Hommey
2019-05-16 3:34 ` Jeff King
2019-05-16 3:28 ` [PATCH 1/2] dup() the input fd for fast-import used for remote helpers Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516083519.5n6qmdw2aaqhjudd@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).